Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

Issue 346513003: Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
index 32729208189eccf5f9cab10504fe2836793d0d6b..494371f1a1a2188ccbbbe40e8f98b64b7b260620 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
@@ -445,6 +445,46 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,
EXPECT_TRUE(keyevent_listener_up.was_satisfied());
}
{
+ SCOPED_TRACE("sendKeyEvents test with keyCode");
+ mock_input_context->Reset();
+ mock_candidate_window->Reset();
+
+ const char send_key_events_test_script[] =
+ "chrome.input.ime.sendKeyEvents({"
+ " contextID: engineBridge.getFocusedContextID().contextID,"
+ " keyData : [{"
+ " type : 'keydown',"
+ " requestId : '2',"
+ " key : 'a',"
+ " code : 'KeyQ',"
+ " keyCode : 0x41,"
+ " },{"
+ " type : 'keyup',"
+ " requestId : '3',"
+ " key : 'a',"
+ " code : 'KeyQ',"
+ " keyCode : 0x41,"
+ " }]"
+ "});";
+
+ ExtensionTestMessageListener keyevent_listener_down(
+ std::string("onKeyEvent:") + kExtensionID +
+ ":keydown:a:KeyQ:false:false:false:false",
+ false);
+ ExtensionTestMessageListener keyevent_listener_up(
+ std::string("onKeyEvent:") + kExtensionID +
+ ":keyup:a:KeyQ:false:false:false:false",
+ false);
+
+ ASSERT_TRUE(content::ExecuteScript(host->host_contents(),
+ send_key_events_test_script));
+
+ ASSERT_TRUE(keyevent_listener_down.WaitUntilSatisfied());
+ EXPECT_TRUE(keyevent_listener_down.was_satisfied());
+ ASSERT_TRUE(keyevent_listener_up.WaitUntilSatisfied());
+ EXPECT_TRUE(keyevent_listener_up.was_satisfied());
+ }
+ {
SCOPED_TRACE("setComposition test");
mock_input_context->Reset();
mock_candidate_window->Reset();

Powered by Google App Engine
This is Rietveld 408576698