Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 346463003: MacViews: Fix missing NSMouseMove in ui::EventTypeFromNative, add test coverage. (Closed)

Created:
6 years, 6 months ago by tapted
Modified:
6 years, 6 months ago
Reviewers:
Robert Sesek, sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix missing NSMouseMove in ui::EventTypeFromNative, add test coverage. Missed a switch case in r266743 (doh). This CL fixes that and adds a bit more test coverage. Testing at this layer hits a limit due to Cocoa API limitations. MacViews will be getting a WidgetEventGenerator in crrev/322893005. BUG=366021, 378134 TEST=events_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278431

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use EnterExitEventWithType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M ui/events/cocoa/events_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/cocoa/events_mac_unittest.mm View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tapted
rsesek for mac sadrul for owners PTAL
6 years, 6 months ago (2014-06-18 08:18:43 UTC) #1
Robert Sesek
https://codereview.chromium.org/346463003/diff/1/ui/events/cocoa/events_mac_unittest.mm File ui/events/cocoa/events_mac_unittest.mm (right): https://codereview.chromium.org/346463003/diff/1/ui/events/cocoa/events_mac_unittest.mm#newcode311 ui/events/cocoa/events_mac_unittest.mm:311: // data validation and throws an exception. There is ...
6 years, 6 months ago (2014-06-18 15:15:01 UTC) #2
tapted
https://codereview.chromium.org/346463003/diff/1/ui/events/cocoa/events_mac_unittest.mm File ui/events/cocoa/events_mac_unittest.mm (right): https://codereview.chromium.org/346463003/diff/1/ui/events/cocoa/events_mac_unittest.mm#newcode311 ui/events/cocoa/events_mac_unittest.mm:311: // data validation and throws an exception. There is ...
6 years, 6 months ago (2014-06-19 00:16:57 UTC) #3
Robert Sesek
LGTM
6 years, 6 months ago (2014-06-19 13:18:37 UTC) #4
sadrul
rsLGTM (events/cocoa/ should have its OWNERS)
6 years, 6 months ago (2014-06-19 13:21:43 UTC) #5
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 6 months ago (2014-06-19 13:38:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/346463003/20001
6 years, 6 months ago (2014-06-19 13:39:34 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 18:24:56 UTC) #8
Message was sent while issue was closed.
Change committed as 278431

Powered by Google App Engine
This is Rietveld 408576698