MacViews: Fix missing NSMouseMove in ui::EventTypeFromNative, add test coverage.

ui/events/cocoa/events_mac_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event_utils.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_cftyperef.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 270 matching lines @@
   // Removing the border, and sending the same event should move it down in the
   // toolkit-views coordinate system.
   int height_change = NSHeight(frame_rect) - kTestHeight;
   EXPECT_GT(height_change, 0);
   [test_window() setStyleMask:NSBorderlessWindowMask];
   [test_window() setFrame:frame_rect display:YES];
   EXPECT_EQ(gfx::Point(0, kTestHeight + height_change),
             ui::EventLocationFromNative(event));
 }
 
+// Testing for ui::EventTypeFromNative() not covered by ButtonEvents.
+TEST_F(EventsMacTest, EventTypeFromNative) {
+  NSEvent* event = cocoa_test_event_utils::KeyEventWithType(NSKeyDown, 0);
+  EXPECT_EQ(ui::ET_KEY_PRESSED, ui::EventTypeFromNative(event));
+
+  event = cocoa_test_event_utils::KeyEventWithType(NSKeyUp, 0);
+  EXPECT_EQ(ui::ET_KEY_RELEASED, ui::EventTypeFromNative(event));
+
+  event = cocoa_test_event_utils::MouseEventWithType(NSLeftMouseDragged, 0);
+  EXPECT_EQ(ui::ET_MOUSE_DRAGGED, ui::EventTypeFromNative(event));
+  event = cocoa_test_event_utils::MouseEventWithType(NSRightMouseDragged, 0);
+  EXPECT_EQ(ui::ET_MOUSE_DRAGGED, ui::EventTypeFromNative(event));
+  event = cocoa_test_event_utils::MouseEventWithType(NSOtherMouseDragged, 0);
+  EXPECT_EQ(ui::ET_MOUSE_DRAGGED, ui::EventTypeFromNative(event));
+
+  event = cocoa_test_event_utils::MouseEventWithType(NSMouseMoved, 0);
+  EXPECT_EQ(ui::ET_MOUSE_MOVED, ui::EventTypeFromNative(event));
+
+  // Attempting to generate mouse events using +[NSEvent mouseEventWithType:..]
+  // for NSMouseExited, NSMouseEntered or NSEventTypeSwipe fails some internal
+  // data validation and throws an exception. There is no corresponding CGEvent

[Robert Sesek, 2014/06/18 15:15:01]

What about using cocoa_test_event_utils::EnterExitEventWithType() ?

[tapted, 2014/06/19 00:16:57]

Ooh - nice. How did I miss that.. Done.

I poked around some more for something on NSEvent to generate NSEventTypeSwipe,
but had no joy there. I'll probably need some state from the EventGenerator to
test these properly anyway.

+  // type for these.
+}
+
 }  // namespace ui