Refactor how we handle resources path in Tests.

Refactor how we handle resources path in Tests.

This idea emerged while doing https://codereview.chromium.org/321723002/
(commit 880914c35c8f7fc2e9c57134134c883baf66e538).

BUG=None
TEST=make tests && out/Debug/tests
R=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/bcbc1788b478b1e54079318ad073e8490aa66fae

[tfarina, 2014-06-17 21:58:24]

Mike, please, let me know what you think.

If you are OK with this, I will update GM and Bench.

Thanks,

[mtklein, 2014-06-18 00:43:02]

On 2014/06/17 21:58:24, tfarina wrote:
> Mike, please, let me know what you think.
> 
> If you are OK with this, I will update GM and Bench.
> 
> Thanks,

Beautiful.  LGTM.  Can you update DM too?  (It's okay that the flag will change
from --resources to --resourcePath in DM).

[tfarina, 2014-06-18 16:08:33]

Mike, please, could you do another pass through my changes?

A sanity and correction check, to make sure I didn't miss anything (as I think
some may not be all that trivial).

Note: The gyp changes are not ideal in my opinion, but I can't do better because
the way it is right now. For example, bench.gyp can't depend on resources target
because it can't include tools.gyp, as tools.gyp already includes bench.gyp and
that would create a circular dependency.

Thanks,

[mtklein, 2014-06-18 18:02:55]

Still looks good to me.  I would prefer we figure out a better GYP configuration
before submitting, but if it's tricky I wouldn't let it block us.

Can we solve the GYP problem by adding a new file gyp/resources.gyp, with just
this one target?  Just ran into a similar problem in this CL and that solved it:
https://codereview.chromium.org/343583005

https://codereview.chromium.org/346453002/diff/60001/gm/cmykjpeg.cpp
File gm/cmykjpeg.cpp (right):

https://codereview.chromium.org/346453002/diff/60001/gm/cmykjpeg.cpp#newcode29
gm/cmykjpeg.cpp:29: SkString resourcePath = GetResourcePath();
Do you have any inclination to do a follow up to turn code like this into just
SkString resourcePath = GetResourcePath("CMYK.jpg"); ?  Should be almost every
file using GetResourcePath() must be doing their own join-directory-and-filename
thing that can all be cleaned up.

[tfarina, 2014-06-18 19:58:23]

GYP changes made.

https://codereview.chromium.org/346453002/diff/60001/gm/cmykjpeg.cpp
File gm/cmykjpeg.cpp (right):

https://codereview.chromium.org/346453002/diff/60001/gm/cmykjpeg.cpp#newcode29
gm/cmykjpeg.cpp:29: SkString resourcePath = GetResourcePath();
On 2014/06/18 18:02:55, mtklein wrote:
> Do you have any inclination to do a follow up to turn code like this into just
> SkString resourcePath = GetResourcePath("CMYK.jpg"); ?
I'll change that in a follow up.

I think it will make the reviewer's life easier (and mine too, in case I make
any mistake).

[tfarina, 2014-06-18 21:17:23]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-06-18 21:17:31]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/346453002/180001

[commit-bot: I haz the power, 2014-06-18 21:32:54]

Change committed as bcbc1788b478b1e54079318ad073e8490aa66fae

[mtklein, 2014-06-18 22:20:02]

> I'll change that in a follow up.
> 
> I think it will make the reviewer's life easier (and mine too, in case I make
> any mistake).

Oh yes, strongly agreed!