Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 343583005: Add basic stacktrace handler using libunwind. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add basic stacktrace handler using libunwind. This means we will all have to apt-get install libunwind8-dev on Linux. Mac comes with everything we need already. BUG=skia: Committed: https://skia.googlesource.com/skia/+/30e6e2af14e84216b1c113fd7500d0822bc81daa

Patch Set 1 #

Patch Set 2 : mac #

Patch Set 3 : LINUX -> UNIX #

Patch Set 4 : note #

Patch Set 5 : all bot tools #

Patch Set 6 : note #

Patch Set 7 : Mac only #

Patch Set 8 : wimpy linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -7 lines) Patch
M bench/benchmain.cpp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M dm/DM.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M gm/gmmain.cpp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/bench.gyp View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
A gyp/crash_handler.gyp View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M gyp/dm.gyp View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
M gyp/gm.gyp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M gyp/tests.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tools.gyp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M tests/skia_test.cpp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A tools/CrashHandler.h View 1 2 3 4 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
A tools/CrashHandler.cpp View 1 2 3 4 5 6 7 1 chunk +88 lines, -0 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
6 years, 6 months ago (2014-06-18 17:36:22 UTC) #1
reed1
nit: lets prefix with Sk or something, or add to sk_tool_utils namespace, or in some ...
6 years, 6 months ago (2014-06-18 17:45:11 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-18 17:52:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/343583005/100001
6 years, 6 months ago (2014-06-18 17:52:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 18:13:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/369)
6 years, 6 months ago (2014-06-18 18:13:21 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-18 18:29:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/343583005/140001
6 years, 6 months ago (2014-06-18 18:29:51 UTC) #8
mtklein
On 2014/06/18 18:29:51, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-18 18:34:25 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 18:44:28 UTC) #10
Message was sent while issue was closed. 
Change committed as 30e6e2af14e84216b1c113fd7500d0822bc81daa

Powered by Google App Engine
This is Rietveld 408576698