Issue 346403002: Initialize WebCore::Frame when swapping frames.

Issue 346403002: Initialize WebCore::Frame when swapping frames. (Closed)

Created:
6 years, 6 months ago by dcheng

Modified:
6 years, 5 months ago

Reviewers:
eseidel

CC:
dcheng, blink-reviews, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Initialize WebCore::Frame when swapping frames. Combine the logic for initializing the WebCore Frame for main frames and child frames so that the logic can be used to initialize WebCore state as well when swapping a local frame in. Also adds a few tests for WebFrame::swap() and fixes a memory leak issue with WebRemoteFrame, due to WebRemoteFrame::close() being unimplemented. BUG=346764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177430

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Oops #

Patch Set 4 : Broken test #

Patch Set 5 : Rebased #

Patch Set 6 : tests, less leaks #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -40 lines)			Patch
M	Source/core/page/Page.cpp	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/web/WebFrame.cpp	View	1 2	5 chunks	+22 lines, -0 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.h	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1 2 3 4	3 chunks	+9 lines, -16 lines	0 comments	Download
M	Source/web/WebRemoteFrameImpl.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebRemoteFrameImpl.cpp	View	1 2 3 4 5	3 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	1 2 3 4 5	2 chunks	+131 lines, -0 lines	0 comments	Download
A	Source/web/tests/data/frame-a-b-c.html	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	Source/web/tests/data/subframe-a.html	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
A +	Source/web/tests/data/subframe-b.html	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
A +	Source/web/tests/data/subframe-c.html	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
A +	Source/web/tests/data/subframe-hello.html	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/346403002/100001

6 years, 5 months ago (2014-07-02 21:52:27 UTC) #4

Message was sent while issue was closed.

Change committed as 177430

Expand Messages | Collapse Messages