Source/web/WebViewImpl.cpp - Issue 346403002: Initialize WebCore::Frame when swapping frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 346403002: Initialize WebCore::Frame when swapping frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: tests, less leaks Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 486ac6de8f3485635f2a5b96e9d226f4feaf3dc8..198a020819cc776452fb6cbe7ea8abef6cae3528 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -317,9 +317,9 @@ void WebView::didExitModalLoop()

void WebViewImpl::setMainFrame(WebFrame* frame)

{

if (frame->isWebLocalFrame())

- toWebLocalFrameImpl(frame)->initializeAsMainFrame(page());

+ toWebLocalFrameImpl(frame)->initializeWebCoreFrame(&page()->frameHost(), 0, nullAtom, nullAtom);

else

- toWebRemoteFrameImpl(frame)->initializeAsMainFrame(page());

+ toWebRemoteFrameImpl(frame)->initializeWebCoreFrame(&page()->frameHost(), 0, nullAtom);

}

void WebViewImpl::setAutofillClient(WebAutofillClient* autofillClient)

« no previous file with comments | « Source/web/WebRemoteFrameImpl.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »