extensions/browser/api/api_resource_manager_unittest.cc - Issue 346193002: Use ExtensionRegistry in EventRouter and ApiResourceManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/api_resource_manager_unittest.cc

Issue 346193002: Use ExtensionRegistry in EventRouter and ApiResourceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/api_resource_manager_unittest.cc

diff --git a/extensions/browser/api/api_resource_manager_unittest.cc b/extensions/browser/api/api_resource_manager_unittest.cc

index 0a86e0ed00e5ce778105fcca6e1ea6f55db192f0..bb57bc5718608c52360c2ec58c5c60e7e7e67e47 100644

--- a/extensions/browser/api/api_resource_manager_unittest.cc

+++ b/extensions/browser/api/api_resource_manager_unittest.cc

@@ -6,6 +6,7 @@

#include "base/strings/string_util.h"

#include "chrome/browser/extensions/extension_function_test_utils.h"

#include "content/public/browser/browser_thread.h"

+#include "content/public/test/test_browser_context.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "extensions/browser/api/api_resource.h"

#include "extensions/browser/api/api_resource_manager.h"

@@ -33,8 +34,10 @@ class FakeApiResource : public ApiResource {

};

TEST_F(ApiResourceManagerUnitTest, TwoAppsCannotShareResources) {

+ scoped_ptr<content::TestBrowserContext> browser_context(

+ new content::TestBrowserContext());

scoped_ptr<ApiResourceManager<FakeApiResource> > manager(

- new ApiResourceManager<FakeApiResource>(NULL));

+ new ApiResourceManager<FakeApiResource>(browser_context.get()));

Devlin 2014/06/25 19:59:54 If I had to guess, I think the reason that the tes

scoped_refptr<extensions::Extension> extension_one(

utils::CreateEmptyExtension("one"));

scoped_refptr<extensions::Extension> extension_two(

« no previous file with comments | « extensions/browser/api/api_resource_manager.h ('k') | extensions/browser/event_router.h » ('j') | extensions/browser/event_router.cc » ('J')