Use ExtensionRegistry in EventRouter and ApiResourceManager

extensions/browser/api/api_resource_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_browser_context.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/browser/api/api_resource.h"
 #include "extensions/browser/api/api_resource_manager.h"
 #include "extensions/common/extension.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace utils = extension_function_test_utils;
 
 using content::BrowserThread;
 
 namespace extensions {
 
 class ApiResourceManagerUnitTest : public testing::Test {
  private:
   content::TestBrowserThreadBundle thread_bundle_;
 };
 
 class FakeApiResource : public ApiResource {
  public:
   explicit FakeApiResource(const std::string& owner_extension_id)
       : ApiResource(owner_extension_id) {}
   virtual ~FakeApiResource() {}
   static const BrowserThread::ID kThreadId = BrowserThread::UI;
 };
 
 TEST_F(ApiResourceManagerUnitTest, TwoAppsCannotShareResources) {
+  scoped_ptr<content::TestBrowserContext> browser_context(
+      new content::TestBrowserContext());
   scoped_ptr<ApiResourceManager<FakeApiResource> > manager(
-      new ApiResourceManager<FakeApiResource>(NULL));
+      new ApiResourceManager<FakeApiResource>(browser_context.get()));

[Devlin, 2014/06/25 19:59:54]

If I had to guess, I think the reason that the tests are failing is because the
BrowserContext is being destroyed before the APIResourceManager.  I'd try
resetting the browser_context at the end of the function and see if that works.

   scoped_refptr<extensions::Extension> extension_one(
       utils::CreateEmptyExtension("one"));
   scoped_refptr<extensions::Extension> extension_two(
       utils::CreateEmptyExtension("two"));
 
   const std::string extension_one_id(extension_one->id());
   const std::string extension_two_id(extension_two->id());
 
   int resource_one_id = manager->Add(new FakeApiResource(extension_one_id));
   int resource_two_id = manager->Add(new FakeApiResource(extension_two_id));
   CHECK(resource_one_id);
   CHECK(resource_two_id);
 
   // Confirm each extension can get its own resource.
   ASSERT_TRUE(manager->Get(extension_one_id, resource_one_id) != NULL);
   ASSERT_TRUE(manager->Get(extension_two_id, resource_two_id) != NULL);
 
   // Confirm neither extension can get the other's resource.
   ASSERT_TRUE(manager->Get(extension_one_id, resource_two_id) == NULL);
   ASSERT_TRUE(manager->Get(extension_two_id, resource_one_id) == NULL);
 
   // And make sure we're not susceptible to any Jedi mind tricks.
   ASSERT_TRUE(manager->Get(std::string(), resource_one_id) == NULL);
 }
 
 }  // namespace extensions