Use ExtensionRegistry in EventRouter and ApiResourceManager

Use ExtensionRegistry in EventRouter and ApiResourceManager

R=rdevlin@chromium.org
BUG=354046

[limasdf, 2014-06-23 14:16:35]

[Working in progress]
Devlin, I have problems to use TestBrowserContext.
but from the codes out there, they use TestBrowserContext.

What's wrong?; if we cannot find a method, I'll take TestingProfile instead.

[Devlin, 2014-06-25 19:59:55]

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/api/a...
File extensions/browser/api/api_resource_manager_unittest.cc (right):

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/api/a...
extensions/browser/api/api_resource_manager_unittest.cc:40: new
ApiResourceManager<FakeApiResource>(browser_context.get()));
If I had to guess, I think the reason that the tests are failing is because the
BrowserContext is being destroyed before the APIResourceManager.  I'd try
resetting the browser_context at the end of the function and see if that works.

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/event...
File extensions/browser/event_router.cc (right):

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/event...
extensions/browser/event_router.cc:694: return;
nit: Can you take out this return while you're here? :)

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/image...
File extensions/browser/image_loader_unittest.cc (right):

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/image...
extensions/browser/image_loader_unittest.cc:12: #include
"chrome/browser/chrome_notification_types.h"
nit: We should be able to remove this and notification_service.h now.

[limasdf, 2014-07-20 06:35:50]

When you have time

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/event...
File extensions/browser/event_router.cc (right):

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/event...
extensions/browser/event_router.cc:694: return;
On 2014/06/25 19:59:54, Devlin wrote:
> nit: Can you take out this return while you're here? :)

Done.

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/image...
File extensions/browser/image_loader_unittest.cc (right):

https://codereview.chromium.org/346193002/diff/50001/extensions/browser/image...
extensions/browser/image_loader_unittest.cc:12: #include
"chrome/browser/chrome_notification_types.h"
On 2014/06/25 19:59:54, Devlin wrote:
> nit: We should be able to remove this and notification_service.h now.

Done. Handled in seperate CL :)

[limasdf, 2014-07-22 01:11:36]

Hold on please. as you already know there's critical issue from
ExtensionsTestBrowserContext :(

and I'm so sorry that I'm bothering you with poor patch T_T, sadly.

[Devlin, 2014-07-24 21:53:44]

On 2014/07/22 01:11:36, limasdf wrote:
> Hold on please. as you already know there's critical issue from
> ExtensionsTestBrowserContext :(
> 
> and I'm so sorry that I'm bothering you with poor patch T_T, sadly.

Don't worry about it - we all missed the problem with the
ExtensionsTestBrowserContext.  It happens. :)  That's why we have a the system
we do - so when we make mistakes (and we all do!!) we can recover quickly. :) 
Lemme know if there's anything I can help with!

Cheers!

[limasdf, 2014-08-02 11:23:45]

On 2014/07/24 21:53:44, Devlin wrote:
> On 2014/07/22 01:11:36, limasdf wrote:
> > Hold on please. as you already know there's critical issue from
> > ExtensionsTestBrowserContext :(
> > 
> > and I'm so sorry that I'm bothering you with poor patch T_T, sadly.
> 
> Don't worry about it - we all missed the problem with the
> ExtensionsTestBrowserContext.  It happens. :)  That's why we have a the system
> we do - so when we make mistakes (and we all do!!) we can recover quickly. :) 
> Lemme know if there's anything I can help with!
> 
> Cheers!

Closed, Because this CL is spilitted and being done from seperate CL.