Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 345903004: Split out libplatform into a separate libary (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
Paweł Hajdan Jr., tfarina, v8-dev
Project:
v8
Visibility:
Public.

Description

Split out libplatform into a separate libary Also remove the "use default platform" compile flag. Instead, the embedder has to provide the platform. Change all binaries to use the default platfrom from libplatform. Unless --job-based-sweeping is passed, nothing uses the platform yet, so nothing will break for embedders (yet). BUG=none R=jkummerow@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=22180

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -67 lines) Patch
M BUILD.gn View 5 chunks +21 lines, -13 lines 4 comments Download
M build/features.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
A include/libplatform/libplatform.h View 1 chunk +27 lines, -0 lines 0 comments Download
M include/v8-platform.h View 2 chunks +2 lines, -3 lines 0 comments Download
M samples/lineprocessor.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M samples/process.cc View 2 chunks +5 lines, -1 line 2 comments Download
M samples/samples.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M samples/shell.cc View 3 chunks +7 lines, -1 line 0 comments Download
M src/DEPS View 1 chunk +8 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/d8.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/d8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/libplatform/default-platform.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mksnapshot.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/v8.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M test/cctest/cctest.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +36 lines, -8 lines 0 comments Download
M tools/lexer-shell.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M tools/lexer-shell.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/parser-shell.cc View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-01 15:44:47 UTC) #1
Jakob Kummerow
LGTM. https://codereview.chromium.org/345903004/diff/1/samples/process.cc File samples/process.cc (right): https://codereview.chromium.org/345903004/diff/1/samples/process.cc#newcode650 samples/process.cc:650: v8::V8::InitializePlatform(platform); Is it intentional that this platform is ...
6 years, 5 months ago (2014-07-02 07:37:52 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/345903004/diff/1/samples/process.cc File samples/process.cc (right): https://codereview.chromium.org/345903004/diff/1/samples/process.cc#newcode650 samples/process.cc:650: v8::V8::InitializePlatform(platform); On 2014/07/02 07:37:52, Jakob wrote: > Is it ...
6 years, 5 months ago (2014-07-02 07:39:25 UTC) #3
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r22180 (presubmit successful).
6 years, 5 months ago (2014-07-03 07:37:56 UTC) #4
tfarina
https://codereview.chromium.org/345903004/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/345903004/diff/1/BUILD.gn#newcode1067 BUILD.gn:1067: source_set("v8_libplatform") { Does this needs visibility? visibility = ":*" ...
6 years, 5 months ago (2014-07-03 18:14:40 UTC) #5
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-03 19:35:20 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/345903004/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/345903004/diff/1/BUILD.gn#newcode1067
BUILD.gn:1067: source_set("v8_libplatform") {
yes, external targets can depend on this

https://codereview.chromium.org/345903004/diff/1/BUILD.gn#newcode1080
BUILD.gn:1080: configs += [ ":internal_config", ":features", ":toolchain" ]
i've modified the configs a bit in a follow-up cl, but essentially, yes, it
does.

Powered by Google App Engine
This is Rietveld 408576698