Split out libplatform into a separate libary

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # TODO(jochen): These will need to be user-settable to support standalone V8
 # builds.
 v8_compress_startup_data = "off"
 v8_deprecation_warnings = false
 v8_enable_disassembler = false
 v8_enable_gdbjit = false
 v8_enable_handle_zapping = true
 v8_enable_i18n_support = true
 v8_enable_verify_heap = false
 v8_interpreted_regexp = false
 v8_object_print = false
 v8_postmortem_support = false
-v8_use_default_platform = true
 v8_use_snapshot = true
 v8_use_external_startup_data = false
 v8_enable_extra_checks = is_debug
 v8_target_arch = cpu_arch
 v8_random_seed = "314159265"
 
 
 ###############################################################################
 # Configurations
 #
@@ skipping 55 matching lines @@
   if (v8_deprecation_warnings == true) {
     defines += [
       "V8_DEPRECATION_WARNINGS",
     ]
   }
   if (v8_enable_i18n_support == true) {
     defines += [
       "V8_I18N_SUPPORT",
     ]
   }
-  if (v8_use_default_platform == true) {
-    defines += [
-      "V8_USE_DEFAULT_PLATFORM",
-    ]
-  }
   if (v8_compress_startup_data == "bz2") {
     defines += [
       "COMPRESS_STARTUP_DATA_BZ2",
     ]
   }
   if (v8_enable_extra_checks == true) {
     defines += [
       "ENABLE_EXTRA_CHECKS",
     ]
   }
@@ skipping 518 matching lines @@
     "src/interface.h",
     "src/interpreter-irregexp.cc",
     "src/interpreter-irregexp.h",
     "src/isolate.cc",
     "src/isolate.h",
     "src/json-parser.h",
     "src/json-stringifier.h",
     "src/jsregexp-inl.h",
     "src/jsregexp.cc",
     "src/jsregexp.h",
-    # TODO(jochen): move libplatform/ files to their own target.
-    "src/libplatform/default-platform.cc",
-    "src/libplatform/default-platform.h",
-    "src/libplatform/task-queue.cc",
-    "src/libplatform/task-queue.h",
-    "src/libplatform/worker-thread.cc",
-    "src/libplatform/worker-thread.h",
     "src/list-inl.h",
     "src/list.h",
     "src/lithium-allocator-inl.h",
     "src/lithium-allocator.cc",
     "src/lithium-allocator.h",
     "src/lithium-codegen.cc",
     "src/lithium-codegen.h",
     "src/lithium.cc",
     "src/lithium.h",
     "src/liveedit.cc",
@@ skipping 417 matching lines @@
     ]
 
     defines += [ "_CRT_RAND_S" ]  # for rand_s()
 
     libs = [ "winmm.lib", "ws2_32.lib" ]
   }
 
   # TODO(jochen): Add support for qnx, freebsd, openbsd, netbsd, and solaris.
 }
 
+source_set("v8_libplatform") {

[tfarina, 2014/07/03 18:14:39]

Does this needs visibility?

visibility = ":*"  # Only targets in this file can depend on this.

v8_libbase has this.

If it does not need, then my understanding is that external targets can depend
on this. Is that right?

[jochen (gone - plz use gerrit), 2014/07/03 19:35:20]

yes, external targets can depend on this

+  sources = [
+    "include/libplatform/libplatform.h",
+    "src/libplatform/default-platform.cc",
+    "src/libplatform/default-platform.h",
+    "src/libplatform/task-queue.cc",
+    "src/libplatform/task-queue.h",
+    "src/libplatform/worker-thread.cc",
+    "src/libplatform/worker-thread.h",
+  ]
+
+  configs -= [ "//build/config/compiler:chromium_code" ]
+  configs += [ "//build/config/compiler:no_chromium_code" ]
+  configs += [ ":internal_config", ":features", ":toolchain" ]

[tfarina, 2014/07/03 18:14:39]

does it need also these configs?

[jochen (gone - plz use gerrit), 2014/07/03 19:35:20]

i've modified the configs a bit in a follow-up cl, but essentially, yes, it
does.

+
+  deps = [
+    ":v8_libbase",
+  ]
+}
+
 ###############################################################################
 # Executables
 #
 
 if (current_toolchain == host_toolchain) {
   executable("mksnapshot") {
     visibility = ":*"  # Only targets in this file can depend on this.
 
     sources = [
       "src/mksnapshot.cc",
     ]
 
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     configs += [ ":internal_config", ":features", ":toolchain" ]
 
     deps = [
       ":v8_base",
+      ":v8_libplatform",
       ":v8_nosnapshot",
     ]
 
     if (v8_compress_startup_data == "bz2") {
       libs = [ "bz2" ]
     }
   }
 }
 
 ###############################################################################
@@ skipping 52 matching lines @@
     deps = [
       ":v8_base",
       ":v8_nosnapshot",
     ]
   }
 
   direct_dependent_configs = [ ":external_config" ]
 }
 
 }