Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 345813005: Rework EventSource CORS tests to be usable from Workers. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rework EventSource CORS tests to be usable from Workers. Improve EventSource-in-Workers test coverage by recasting existing CORS tests as js-test.js tests, enabling them to also be testable from within Workers. As was, we had no such Worker test coverage. Also add two new tests covering failure-on-redirect handling: one due to the CORS access check, the other due to CSP connect-src's. R=abarth@chromium.org,mkwst@chromium.org BUG=386520 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176950

Patch Set 1 #

Total comments: 2

Patch Set 2 : Generalize redirect.php?cors_enabled to cors_allow_origin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -288 lines) Patch
M LayoutTests/http/tests/eventsource/eventsource-cors-basic.html View 1 chunk +3 lines, -82 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-cors-basic-expected.txt View 1 chunk +26 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-cors-no-server.html View 1 chunk +3 lines, -55 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-cors-no-server-expected.txt View 1 chunk +11 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-cors-non-http.html View 1 chunk +3 lines, -27 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-cors-non-http-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/eventsource-cors-redirect.html View 1 chunk +1 line, -5 lines 0 comments Download
A LayoutTests/http/tests/eventsource/eventsource-cors-redirect-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-cors-with-credentials.html View 1 chunk +3 lines, -82 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-cors-with-credentials-expected.txt View 1 chunk +29 lines, -11 lines 0 comments Download
A LayoutTests/http/tests/eventsource/eventsource-csp-redirect.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/eventsource-csp-redirect-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-cors-basic.js View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-cors-no-server.js View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-cors-non-http.js View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-cors-redirect.js View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-cors-with-credentials.js View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-csp-redirect.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-cors-basic.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-cors-basic-expected.txt View 1 chunk +29 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-cors-no-server.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-cors-no-server-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-cors-non-http.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-cors-non-http-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-cors-redirect.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-cors-redirect-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-cors-with-credentials.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-cors-with-credentials-expected.txt View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-csp-redirect.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-csp-redirect-expected.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/resources/redirect.php View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look. Improve CORS+CSP testing for EventSource-in-Workers a bit; depends on https://codereview.chromium.org/340363003/
6 years, 6 months ago (2014-06-22 13:30:33 UTC) #1
abarth-chromium
rslgtm
6 years, 6 months ago (2014-06-22 14:48:55 UTC) #2
Mike West
The tests are much clean, thanks for putting this patch together. LGTM. https://codereview.chromium.org/345813005/diff/1/LayoutTests/http/tests/resources/redirect.php File LayoutTests/http/tests/resources/redirect.php ...
6 years, 6 months ago (2014-06-23 06:13:37 UTC) #3
sof
https://codereview.chromium.org/345813005/diff/1/LayoutTests/http/tests/resources/redirect.php File LayoutTests/http/tests/resources/redirect.php (right): https://codereview.chromium.org/345813005/diff/1/LayoutTests/http/tests/resources/redirect.php#newcode13 LayoutTests/http/tests/resources/redirect.php:13: header("Access-Control-Allow-Origin: *"); On 2014/06/23 06:13:37, Mike West wrote: > ...
6 years, 6 months ago (2014-06-23 06:42:18 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-25 20:30:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/345813005/20001
6 years, 6 months ago (2014-06-25 20:31:22 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 21:36:42 UTC) #7
Message was sent while issue was closed.
Change committed as 176950

Powered by Google App Engine
This is Rietveld 408576698