LayoutTests/http/tests/resources/redirect.php - Issue 345813005: Rework EventSource CORS tests to be usable from Workers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/resources/redirect.php

Issue 345813005: Rework EventSource CORS tests to be usable from Workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?php	1 <?php

2 $url = $_GET['url'];	2 $url = $_GET['url'];

3 $refresh = $_GET['refresh'];	3 $refresh = $_GET['refresh'];

4	4

5 if (isset($refresh)) {	5 if (isset($refresh)) {

6 header("HTTP/1.1 200");	6 header("HTTP/1.1 200");

7 header("Refresh: $refresh; url=$url");	7 header("Refresh: $refresh; url=$url");

8 return;	8 return;

9 }	9 }

10	10

	11 header("Location: $url");

	12 if (isset($_GET['cors_enabled']))

	13 header("Access-Control-Allow-Origin: *");
	Mike West 2014/06/23 06:13:37 It doesn't matter for any of these tests, but it m It doesn't matter for any of these tests, but it might be reasonable to change the hard-coded '' into a GET param to check redirect behavior in a future patch. sof* 2014/06/23 06:42:18 Good idea, a redirect script this "high up" is bet Show quoted text On 2014/06/23 06:13:37, Mike West wrote: > It doesn't matter for any of these tests, but it might be reasonable to change > the hard-coded '*' into a GET param to check redirect behavior in a future > patch. Good idea, a redirect script this "high up" is better off parameterizing that out. Added 'cors_allow_origin' (instead of 'cors_enabled'.)
	14

11 $code = $_GET['code'];	15 $code = $_GET['code'];

12 if (!isset($code))	16 if (!isset($code))

13 $code = 302;	17 $code = 302;

14 header("HTTP/1.1 $code");	18 header("HTTP/1.1 $code");

15 header("Location: $url");

16 ?>	19 ?>

OLD	NEW

« no previous file with comments | « LayoutTests/http/tests/eventsource/workers/eventsource-csp-redirect-expected.txt ('k') | no next file » | no next file with comments »