Translate: Hide the bubble if the user denies translating 2 times within 24 hours

components/translate/core/browser/translate_prefs.h

Index: components/translate/core/browser/translate_prefs.h
diff --git a/components/translate/core/browser/translate_prefs.h b/components/translate/core/browser/translate_prefs.h
index 6b15c9e1922e05b8045dd4c4bec406e4fa10d649..9d2b1cad03bc4b2e3373395edcdbec3e19273264 100644
--- a/components/translate/core/browser/translate_prefs.h
+++ b/components/translate/core/browser/translate_prefs.h
@@ -35,6 +35,8 @@ class TranslatePrefs {
   static const char kPrefTranslateDeniedCount[];
   static const char kPrefTranslateAcceptedCount[];
   static const char kPrefTranslateBlockedLanguages[];
+  static const char kPrefTranslateBubbleLastClosedTime[];
+  static const char kPrefTranslateBubbleHidden[];
 
   // |preferred_languages_pref| is only used on Chrome OS, other platforms must
   // pass NULL.
@@ -87,6 +89,9 @@ class TranslatePrefs {
   void IncrementTranslationAcceptedCount(const std::string& language);
   void ResetTranslationAcceptedCount(const std::string& language);
 
+  void UpdateBubbleLastClosedTime();

[droger, 2014/06/20 12:09:29]

Can we have comments for these methods?

+  bool IsBubbleHidden() const;

[droger, 2014/06/20 12:09:29]

This class is used both by infobars and bubbles, and does not mention any
particular UI type.
I'd prefer more generic names. Example: UpdateTranslationDialogClosedTime() and
IsTranslationDialogHidden().

[hajimehoshi, 2014/06/20 14:15:45]

Hmm, the confusing thing is that the new feature to hide the UI is applied only
for bubble. Bubble won't be shown automatically forever with two or more
denials, but we don't change Infobar's behavior with this CL.

[Takashi Toyoshima, 2014/06/23 11:13:30]

As droger said, having bubble UI specific functions inside this class is a kind
of layering violation. We should not mention a specific UI implementation here.
So even these function are used only by bubble UI, we should use abstracted
names here.

[hajimehoshi, 2014/06/24 06:17:53]

OK, I renamed them to UpdateLastDeniedTime and IsTooOftenDenied. Done.

+
   // Gets the language list of the language settings.
   void GetLanguageList(std::vector<std::string>* languages);