Translate: Hide the bubble if the user denies translating 2 times within 24 hours

components/translate/core/browser/translate_prefs.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_
 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 17 matching lines @@
 //
 // It is assumed that |prefs_| is alive while this instance is alive.
 class TranslatePrefs {
  public:
   static const char kPrefTranslateLanguageBlacklist[];
   static const char kPrefTranslateSiteBlacklist[];
   static const char kPrefTranslateWhitelists[];
   static const char kPrefTranslateDeniedCount[];
   static const char kPrefTranslateAcceptedCount[];
   static const char kPrefTranslateBlockedLanguages[];
+  static const char kPrefTranslateBubbleLastClosedTime[];
+  static const char kPrefTranslateBubbleHidden[];
 
   // |preferred_languages_pref| is only used on Chrome OS, other platforms must
   // pass NULL.
   TranslatePrefs(PrefService* user_prefs,
                  const char* accept_languages_pref,
                  const char* preferred_languages_pref);
 
   // Resets the blocked languages list, the sites blacklist, the languages
   // whitelist, and the accepted/denied counts.
   void ResetToDefaults();
@@ skipping 32 matching lines @@
   void IncrementTranslationDeniedCount(const std::string& language);
   void ResetTranslationDeniedCount(const std::string& language);
 
   // These methods are used to track how many times the user has accepted the
   // translation for a specific language. (So we can present a UI to white-list
   // that language if the user keeps accepting translations).
   int GetTranslationAcceptedCount(const std::string& language);
   void IncrementTranslationAcceptedCount(const std::string& language);
   void ResetTranslationAcceptedCount(const std::string& language);
 
+  void UpdateBubbleLastClosedTime();

[droger, 2014/06/20 12:09:29]

Can we have comments for these methods?

+  bool IsBubbleHidden() const;

[droger, 2014/06/20 12:09:29]

This class is used both by infobars and bubbles, and does not mention any
particular UI type.
I'd prefer more generic names. Example: UpdateTranslationDialogClosedTime() and
IsTranslationDialogHidden().

[hajimehoshi, 2014/06/20 14:15:45]

Hmm, the confusing thing is that the new feature to hide the UI is applied only
for bubble. Bubble won't be shown automatically forever with two or more
denials, but we don't change Infobar's behavior with this CL.

[Takashi Toyoshima, 2014/06/23 11:13:30]

As droger said, having bubble UI specific functions inside this class is a kind
of layering violation. We should not mention a specific UI implementation here.
So even these function are used only by bubble UI, we should use abstracted
names here.

[hajimehoshi, 2014/06/24 06:17:53]

OK, I renamed them to UpdateLastDeniedTime and IsTooOftenDenied. Done.

+
   // Gets the language list of the language settings.
   void GetLanguageList(std::vector<std::string>* languages);
 
   // Updates the language list of the language settings.
   void UpdateLanguageList(const std::vector<std::string>& languages);
 
   bool CanTranslateLanguage(TranslateAcceptLanguages* accept_languages,
                             const std::string& language);
   bool ShouldAutoTranslate(const std::string& original_language,
                            std::string* target_language);
@@ skipping 45 matching lines @@
   // Retrieves the dictionary mapping the number of times translation has been
   // accepted for a language, creating it if necessary.
   base::DictionaryValue* GetTranslationAcceptedCountDictionary() const;
 
   PrefService* prefs_;  // Weak.
 
   DISALLOW_COPY_AND_ASSIGN(TranslatePrefs);
 };
 
 #endif  // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_