Extensions: Split extensions utility IPC messages into its own file.

Extensions: Split extensions utility IPC messages into its own file.

Disable extensions code on Android so they do not use these messages.

BUG=349436
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280242

[Lei Zhang, 2014-06-20 23:22:04]

This is a big one and shaves ~200 KB off the chrome shell APK. ExtensionService
is the stopping point in extensions code at which point I start #ifdefing.

https://codereview.chromium.org/345693002/diff/190001/chrome/browser/extensio...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/345693002/diff/190001/chrome/browser/extensio...
chrome/browser/extensions/tab_helper.cc:110: #if defined(ENABLE_EXTENSIONS)
I'll likely land https://codereview.chromium.org/349713002/ before this, so this
will get reverted. But for now...

[Yoyo Zhou, 2014-06-25 01:17:50]

LGTM

https://chromiumcodereview.appspot.com/345693002/diff/350001/chrome/utility/c...
File chrome/utility/chrome_content_utility_client.cc (right):

https://chromiumcodereview.appspot.com/345693002/diff/350001/chrome/utility/c...
chrome/utility/chrome_content_utility_client.cc:300: // TODO(thestig) Try to
move this to
nit: TODO(thestig):
Do you want to put this todo on the message itself?

https://chromiumcodereview.appspot.com/345693002/diff/350001/chrome/utility/c...
File chrome/utility/chrome_content_utility_ipc_whitelist.cc (right):

https://chromiumcodereview.appspot.com/345693002/diff/350001/chrome/utility/c...
chrome/utility/chrome_content_utility_ipc_whitelist.cc:15: #endif
keep the // comment for clarity

[Lei Zhang, 2014-06-25 02:55:41]

+palmer for IPC changes.

[Lei Zhang, 2014-06-25 07:14:29]

https://codereview.chromium.org/345693002/diff/350001/chrome/utility/chrome_c...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/345693002/diff/350001/chrome/utility/chrome_c...
chrome/utility/chrome_content_utility_client.cc:300: // TODO(thestig) Try to
move this to
On 2014/06/25 01:17:49, Yoyo Zhou wrote:
> nit: TODO(thestig):

Done.

> Do you want to put this todo on the message itself?

The message has been moved. It's just the implementation here adds a new
handler.

https://codereview.chromium.org/345693002/diff/350001/chrome/utility/chrome_c...
File chrome/utility/chrome_content_utility_ipc_whitelist.cc (right):

https://codereview.chromium.org/345693002/diff/350001/chrome/utility/chrome_c...
chrome/utility/chrome_content_utility_ipc_whitelist.cc:15: #endif
On 2014/06/25 01:17:50, Yoyo Zhou wrote:
> keep the // comment for clarity

Done.

[palmer, 2014-06-25 19:07:51]

IPC security LGTM.

[Lei Zhang, 2014-06-25 19:19:48]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-25 19:21:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/345693002/410001

[commit-bot: I haz the power, 2014-06-25 20:37:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-25 21:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 21:59:07]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Lei Zhang, 2014-06-26 16:54:15]

ChromeExtensionsBrowserClient isn't ready to leave just yet. So I reverted that
part. (Patch set 10 -> 12)

[Lei Zhang, 2014-06-26 16:57:42]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-26 16:59:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/345693002/470001

[commit-bot: I haz the power, 2014-06-26 19:29:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-26 19:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 19:35:32]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Lei Zhang, 2014-06-26 20:55:00]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-26 20:58:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/345693002/510001

[commit-bot: I haz the power, 2014-06-26 22:23:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/22154)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/26496)

[Lei Zhang, 2014-06-26 22:32:53]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-26 22:34:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/345693002/500039

[Lei Zhang, 2014-06-27 00:42:29]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-06-27 02:59:31]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-27 03:03:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/345693002/540001

[commit-bot: I haz the power, 2014-06-27 04:52:40]

Change committed as 280242