chrome/browser/extensions/updater/safe_manifest_parser.cc - Issue 345693002: Extensions: Split extensions utility IPC messages into its own file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/updater/safe_manifest_parser.cc

Issue 345693002: Extensions: Split extensions utility IPC messages into its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: disable another test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/sandboxed_unpacker.cc ('k') | chrome/browser/extensions/webstore_install_helper.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/updater/safe_manifest_parser.h"	5 #include "chrome/browser/extensions/updater/safe_manifest_parser.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/command_line.h"	8 #include "base/command_line.h"

9 #include "base/location.h"	9 #include "base/location.h"

10 #include "base/logging.h"	10 #include "base/logging.h"

11 #include "chrome/common/chrome_utility_messages.h"	11 #include "chrome/common/extensions/chrome_utility_extensions_messages.h"

12 #include "content/public/browser/browser_thread.h"	12 #include "content/public/browser/browser_thread.h"

13 #include "content/public/browser/utility_process_host.h"	13 #include "content/public/browser/utility_process_host.h"

14 #include "content/public/common/content_switches.h"	14 #include "content/public/common/content_switches.h"

15 #include "ipc/ipc_message_macros.h"	15 #include "ipc/ipc_message_macros.h"

16	16

17 using content::BrowserThread;	17 using content::BrowserThread;

18	18

19 namespace extensions {	19 namespace extensions {

20	20

21 SafeManifestParser::SafeManifestParser(const std::string& xml,	21 SafeManifestParser::SafeManifestParser(const std::string& xml,

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71	71

72 void SafeManifestParser::OnParseUpdateManifestFailed(	72 void SafeManifestParser::OnParseUpdateManifestFailed(

73 const std::string& error_message) {	73 const std::string& error_message) {

74 VLOG(2) << "parsing manifest failed (" << fetch_data_->full_url() << ")";	74 VLOG(2) << "parsing manifest failed (" << fetch_data_->full_url() << ")";

75 DCHECK_CURRENTLY_ON(BrowserThread::UI);	75 DCHECK_CURRENTLY_ON(BrowserThread::UI);

76 LOG(WARNING) << "Error parsing update manifest:\n" << error_message;	76 LOG(WARNING) << "Error parsing update manifest:\n" << error_message;

77 update_callback_.Run(*fetch_data_, NULL);	77 update_callback_.Run(*fetch_data_, NULL);

78 }	78 }

79	79

80 } // namespace extensions	80 } // namespace extensions

OLD	NEW