Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 345673002: Fully qualify all references to fileapi::FileSystemType (Closed)

Created:
6 years, 6 months ago by Reid Kleckner
Modified:
6 years, 6 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik, kinuko
Project:
chromium
Visibility:
Public.

Description

Fully qualify all references to fileapi::FileSystemType This avoids a name conflict between winnt.h's FileSystemType enumerator value and Chromium's fileapi::FileSystemType enum type. MSVC doesn't care, but Clang diagnoses this with: error: must use 'enum' tag to refer to type 'FileSystemType' in this scope I could use the enum tag to avoid this ambiguity, but it would be very inconsistent with other Chromium code. A full nested name specifier seems better. R=thakis@chromium.org,hans@chromium.org TBR=kinuko@chromium.org BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278332

Patch Set 1 #

Patch Set 2 : Fix FileSystemType instances I missed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -91 lines) Patch
M content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 4 chunks +9 lines, -11 lines 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/fileapi/file_system_quota_client_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/fileapi/isolated_context_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/quota/quota_backend_impl_unittest.cc View 9 chunks +10 lines, -9 lines 0 comments Download
M content/browser/quota/quota_reservation_manager_unittest.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M content/browser/renderer_host/pepper/quota_reservation_unittest.cc View 7 chunks +9 lines, -10 lines 0 comments Download
M content/common/fileapi/file_system_util_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/public/test/sandbox_file_system_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/test_file_system_backend.cc View 1 6 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Reid Kleckner
6 years, 6 months ago (2014-06-18 23:22:42 UTC) #1
hans
lgtm
6 years, 6 months ago (2014-06-18 23:35:21 UTC) #2
Nico
Prior art: https://codereview.chromium.org/14615015 kinuko said they're considering renaming their enum in that review; maybe it'll ...
6 years, 6 months ago (2014-06-18 23:39:31 UTC) #3
Reid Kleckner
Fix FileSystemType instances I missed
6 years, 6 months ago (2014-06-19 01:23:55 UTC) #4
Reid Kleckner
The CQ bit was checked by rnk@chromium.org
6 years, 6 months ago (2014-06-19 01:24:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/345673002/20001
6 years, 6 months ago (2014-06-19 01:30:34 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 11:42:34 UTC) #7
Message was sent while issue was closed.
Change committed as 278332

Powered by Google App Engine
This is Rietveld 408576698