Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 14615015: Fix name conflict with FileSystemType from winnt.h (Closed)

Created:
7 years, 7 months ago by Reid Kleckner
Modified:
7 years, 7 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, tommycli
Visibility:
Public.

Description

Fix name conflict with FileSystemType from winnt.h winnt.h has this enum in global scope: typedef enum _CM_SERVICE_NODE_TYPE { ... FileSystemType = SERVICE_FILE_SYSTEM_DRIVER, ... } SERVICE_NODE_TYPE; Clang complains that references to FileSystemType are ambiguous. It suggests using 'enum FileSystemType' to resolve the ambiguity, but that seems weird in C++. Instead, I changed the uses in this file to fileapi::FileSystemType and left a comment where the using decl would naturally go. R=kinuko@chromium.org BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc View 8 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Reid Kleckner
7 years, 7 months ago (2013-05-16 19:18:41 UTC) #1
kinuko
(+vandebo, tommycli) Gush, thanks for catching this. We'll consider renaming the type name as well... ...
7 years, 7 months ago (2013-05-17 02:11:32 UTC) #2
Reid Kleckner
7 years, 7 months ago (2013-05-17 14:08:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r200813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698