Issue 345653004: Removes the restriction of onFocus event on password field to 3rd party IMEs.

Issue 345653004: Removes the restriction of onFocus event on password field to 3rd party IMEs. (Closed)

Created:
6 years, 6 months ago by Shu Chen

Modified:
6 years, 6 months ago

Reviewers:
not at google - send to devlin, Seigo Nonaka

CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Removes the restriction of onFocus event on password field to 3rd party IMEs. BUG=356569 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278701

Patch Set 1 #

Patch Set 2 : make unit_tests pass. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -24 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_engine.cc	View	1	2 chunks	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_unittest.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/api/input_ime.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Shu Chen

kalman@/nona@, can you please review this cl? kalman@ for json file change. nona@ for input ...

6 years, 6 months ago (2014-06-19 04:28:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/345653004/20001

6 years, 6 months ago (2014-06-20 00:41:20 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 6 months ago (2014-06-20 10:34:21 UTC) #6

Message was sent while issue was closed.

Change committed as 278701

Expand Messages | Collapse Messages