Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 345653004: Removes the restriction of onFocus event on password field to 3rd party IMEs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make unit_tests pass. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_engine_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_engine.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc
index adac10d1df323926024f928b737d4e4405b2467e..03d8ada3c5b683c5e7a8a891cf72035b1cd8f582 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc
@@ -509,16 +509,6 @@ void InputMethodEngine::FocusIn(
if (!active_ || current_input_type_ == ui::TEXT_INPUT_TYPE_NONE)
return;
- // Prevent sending events on password field to 3rd-party IME extensions.
- // And also make sure the VK fallback to system VK.
- // TODO(shuchen): for password field, forcibly switch/lock the IME to the XKB
- // keyboard related to the current IME.
- if (current_input_type_ == ui::TEXT_INPUT_TYPE_PASSWORD &&
- !extension_ime_util::IsComponentExtensionIME(GetDescriptor().id())) {
- EnableInputView(false);
- return;
- }
-
context_id_ = next_context_id_;
++next_context_id_;
@@ -555,17 +545,8 @@ void InputMethodEngine::FocusOut() {
if (!active_ || current_input_type_ == ui::TEXT_INPUT_TYPE_NONE)
return;
- ui::TextInputType previous_input_type = current_input_type_;
current_input_type_ = ui::TEXT_INPUT_TYPE_NONE;
- // Prevent sending events on password field to 3rd-party IME extensions.
- // And also make sure the VK restore to IME input view.
- if (previous_input_type == ui::TEXT_INPUT_TYPE_PASSWORD &&
- !extension_ime_util::IsComponentExtensionIME(GetDescriptor().id())) {
- EnableInputView(true);
- return;
- }
-
int context_id = context_id_;
context_id_ = -1;
observer_->OnBlur(context_id);
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_engine_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698