Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 345643002: Fix JS_WIDESTRING to work with clang-cl (Closed)

Created:
6 years, 6 months ago by Reid Kleckner
Modified:
6 years, 6 months ago
Reviewers:
Bo Xu, jun_fang, jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fix JS_WIDESTRING to work with clang-cl MSVC lexes L#macro_arg as a single wide string literal token, but Clang and other C/C++ compliant lexers do not. There was already a workaround to use implicit string concatenation for GCC, but there's a simpler solution of token pasting the L onto the stringized macro argument with 'L###macro_arg'. This works with Clang, GCC, and MSVC. R=jun_fang@foxitsoftware.com, jam@chromium.org BUG=82385 Original patch by Reid Kleckner <rnk@chromium.org>; Committed: https://pdfium.googlesource.com/pdfium/+/63412bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M fpdfsdk/include/javascript/JS_Define.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Reid Kleckner
6 years, 6 months ago (2014-06-18 21:55:18 UTC) #1
jam
Redirecting to Bo or Jun
6 years, 6 months ago (2014-06-18 22:19:41 UTC) #2
jun_fang
On 2014/06/18 22:19:41, jam wrote: > Redirecting to Bo or Jun LGTM
6 years, 6 months ago (2014-06-19 00:42:20 UTC) #3
jam
6 years, 6 months ago (2014-06-19 15:07:42 UTC) #4
Message was sent while issue was closed.
On 2014/06/19 00:42:20, jun_fang wrote:
> On 2014/06/18 22:19:41, jam wrote:
> > Redirecting to Bo or Jun
> 
> LGTM

Thanks, committed in https://pdfium.googlesource.com/pdfium/+/63412bf

Powered by Google App Engine
This is Rietveld 408576698