fpdfsdk/include/javascript/JS_Define.h - Issue 345643002: Fix JS_WIDESTRING to work with clang-cl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/JS_Define.h

Issue 345643002: Fix JS_WIDESTRING to work with clang-cl (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/javascript/JS_Define.h

diff --git a/fpdfsdk/include/javascript/JS_Define.h b/fpdfsdk/include/javascript/JS_Define.h

index cc203337062f431523c7a739c9ffa9205c07b3ed..ba978e9e2d36f6e8b4c7e359dc20ab96f75a417e 100644

--- a/fpdfsdk/include/javascript/JS_Define.h

+++ b/fpdfsdk/include/javascript/JS_Define.h

@@ -44,11 +44,7 @@ typedef CFX_WideString JS_ErrorString;

#define CJS_IntArray CFX_ArrayTemplate<int>

/* ====================================== PUBLIC DEFINE SPEC ============================================== */

-#ifndef __GNUC__

-#define JS_WIDESTRING(widestring) L#widestring

-#else

-#define JS_WIDESTRING(widestring) L""#widestring

-#endif

+#define JS_WIDESTRING(widestring) L###widestring

#define OBJ_PROP_PARAMS IFXJS_Context* cc, CJS_PropValue& vp, JS_ErrorString& sError

#define OBJ_METHOD_PARAMS IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, JS_ErrorString& sError

« no previous file with comments | « no previous file | no next file » | no next file with comments »