Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345603003: aura: Allow specifying the size of TestScreen when creating it. (Closed)

Created:
6 years, 6 months ago by sadrul
Modified:
6 years, 6 months ago
Reviewers:
James Cook, sky, pfeldman
CC:
chromium-reviews, tim+watch_chromium.org, jam, ben+aura_chromium.org, tfarina, haitaol+watch_chromium.org, darin-cc_chromium.org, kalyank, chromium-apps-reviews_chromium.org, jdduke+watch_chromium.org, jochen+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

aura: Allow specifying the size of TestScreen when creating it. BUG=380215 R=jamescook@chromium.org, sky@chromium.org TBR=pfeldman@ for content/shell changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278697

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M apps/shell/browser/shell_desktop_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M athena/test/athena_test_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_views.cc View 1 chunk +2 lines, -2 lines 2 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/test/test_screen.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/aura/test/test_screen.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts_chromeos.cc View 1 chunk +5 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
sadrul
6 years, 6 months ago (2014-06-18 19:22:38 UTC) #1
sky
https://codereview.chromium.org/345603003/diff/1/content/shell/browser/shell_views.cc File content/shell/browser/shell_views.cc (right): https://codereview.chromium.org/345603003/diff/1/content/shell/browser/shell_views.cc#newcode427 content/shell/browser/shell_views.cc:427: aura::TestScreen::Create(gfx::Size())); Does this leak? https://codereview.chromium.org/345603003/diff/1/ui/views_content_client/views_content_client_main_parts_chromeos.cc File ui/views_content_client/views_content_client_main_parts_chromeos.cc (right): https://codereview.chromium.org/345603003/diff/1/ui/views_content_client/views_content_client_main_parts_chromeos.cc#newcode67 ...
6 years, 6 months ago (2014-06-19 14:51:08 UTC) #2
sadrul
https://codereview.chromium.org/345603003/diff/1/content/shell/browser/shell_views.cc File content/shell/browser/shell_views.cc (right): https://codereview.chromium.org/345603003/diff/1/content/shell/browser/shell_views.cc#newcode427 content/shell/browser/shell_views.cc:427: aura::TestScreen::Create(gfx::Size())); On 2014/06/19 14:51:08, sky wrote: > Does this ...
6 years, 6 months ago (2014-06-19 16:01:23 UTC) #3
sky
LGTM on this one then
6 years, 6 months ago (2014-06-19 20:11:53 UTC) #4
sadrul
+jamescook@ for apps/ owner +pfeldman@ for content/shell/ owner
6 years, 6 months ago (2014-06-19 22:26:16 UTC) #5
James Cook
LGTM for apps/shell I vaguely remember oshima saying he was intentionally leaking screen objects -- ...
6 years, 6 months ago (2014-06-20 00:05:47 UTC) #6
sadrul
On 2014/06/20 00:05:47, James Cook wrote: > LGTM for apps/shell > > I vaguely remember ...
6 years, 6 months ago (2014-06-20 01:00:07 UTC) #7
sadrul
The change in content/shell is fairly trivial. So I am going to TBR that
6 years, 6 months ago (2014-06-20 13:18:18 UTC) #8
sadrul
6 years, 6 months ago (2014-06-20 13:18:42 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 manually as r278697 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698