Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/browser/service_worker/service_worker_unregister_job.cc

Issue 345583002: ServiceWorker: Add a function to abort all pending jobs in SWJobCoordinator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments and add test cases Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_unregister_job.cc
diff --git a/content/browser/service_worker/service_worker_unregister_job.cc b/content/browser/service_worker/service_worker_unregister_job.cc
index a66f32f5fc4486d4e3f9eb04dddd2f50cce3d4f5..dabcd22f1087c7daed227aa2c66fe5f19c925d15 100644
--- a/content/browser/service_worker/service_worker_unregister_job.cc
+++ b/content/browser/service_worker/service_worker_unregister_job.cc
@@ -34,6 +34,10 @@ void ServiceWorkerUnregisterJob::Start() {
weak_factory_.GetWeakPtr()));
}
+void ServiceWorkerUnregisterJob::Abort() {
+ CompleteInternal(SERVICE_WORKER_ERROR_ABORT);
+}
+
bool ServiceWorkerUnregisterJob::Equals(ServiceWorkerRegisterJobBase* job) {
if (job->GetType() != GetType())
return false;
@@ -70,12 +74,17 @@ void ServiceWorkerUnregisterJob::DeleteExistingRegistration(
}
void ServiceWorkerUnregisterJob::Complete(ServiceWorkerStatusCode status) {
+ CompleteInternal(status);
+ context_->job_coordinator()->FinishJob(pattern_, this);
+}
+
+void ServiceWorkerUnregisterJob::CompleteInternal(
+ ServiceWorkerStatusCode status) {
for (std::vector<UnregistrationCallback>::iterator it = callbacks_.begin();
it != callbacks_.end();
++it) {
it->Run(status);
}
- context_->job_coordinator()->FinishJob(pattern_, this);
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698