content/browser/service_worker/service_worker_register_job_base.h - Issue 345583002: ServiceWorker: Add a function to abort all pending jobs in SWJobCoordinator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job_base.h

Issue 345583002: ServiceWorker: Add a function to abort all pending jobs in SWJobCoordinator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments and add test cases Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_register_job.cc ('K') | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_unregister_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job_base.h

diff --git a/content/browser/service_worker/service_worker_register_job_base.h b/content/browser/service_worker/service_worker_register_job_base.h

index f292ee36a1eeb4e0a74ab6e95582ffa675c07d79..ec250820ef68aff5c958141bf53e33a072ec0bd2 100644

--- a/content/browser/service_worker/service_worker_register_job_base.h

+++ b/content/browser/service_worker/service_worker_register_job_base.h

@@ -18,6 +18,9 @@ class ServiceWorkerRegisterJobBase {

// Starts the job. This method should be called once and only once per job.

virtual void Start() = 0;

+ // Aborts the job. This method should be called once and only once per job.

falken 2014/06/19 08:10:56 Maybe add "It can be called regardless of whether

nhiroki 2014/06/19 10:04:05 Done.

+ virtual void Abort() = 0;

// Returns true if this job is identical to |job| for the purpose of

// collapsing them together in a ServiceWorkerJobCoordinator queue.

// Registration jobs are equal if they are for the same pattern and script