Chromium Code Reviews| Index: runtime/bin/vmservice/client/lib/src/elements/class_view.html |
| =================================================================== |
| --- runtime/bin/vmservice/client/lib/src/elements/class_view.html (revision 37499) |
| +++ runtime/bin/vmservice/client/lib/src/elements/class_view.html (working copy) |
| @@ -86,12 +86,28 @@ |
| <div class="memberValue">{{ cls.vmName }}</div> |
| </div> |
| </template> |
| - <div class="memberItem"> |
| - <div class="memberName">retained size<br>(all instances)</div> |
| - <div class="memberValue"> |
| - <eval-link callback="{{ retainedSize }}"></eval-link> |
| + |
| + <template if="{{ !cls.hasNoAllocations }}"> |
| + <div class="memberItem"> </div> |
| + <div class="memberItem"> |
| + <div class="memberName">current instances</div> |
| + <div class="memberValue"> |
| + {{ cls.newSpace.current.instances + cls.oldSpace.current.instances }} |
| + </div> |
| </div> |
| - </div> |
| + <div class="memberItem"> |
| + <div class="memberName">shallow size</div> |
|
Cutch
2014/06/20 18:10:49
shallow size (of all instances)?
koda
2014/06/20 18:37:03
I made a "current instances" section instead. See
|
| + <div class="memberValue"> |
| + {{ cls.newSpace.current.bytes + cls.oldSpace.current.bytes }} |
|
Cutch
2014/06/20 18:10:49
I think this might double count. I'm not sure the
koda
2014/06/20 18:37:04
I think that's true, and that the correct solution
|
| + </div> |
| + </div> |
| + <div class="memberItem"> |
| + <div class="memberName">retained size</div> |
|
Cutch
2014/06/20 18:10:49
(of all instances)?
koda
2014/06/20 18:37:04
See above.
|
| + <div class="memberValue"> |
| + <eval-link callback="{{ retainedSize }}"></eval-link> |
| + </div> |
| + </div> |
| + </template> |
| </div> |
| </div> |