Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/class_view.html

Issue 345543003: Send allocation stats with each class and show in class view. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/class_view.html
===================================================================
--- runtime/bin/vmservice/client/lib/src/elements/class_view.html (revision 37499)
+++ runtime/bin/vmservice/client/lib/src/elements/class_view.html (working copy)
@@ -86,12 +86,28 @@
<div class="memberValue">{{ cls.vmName }}</div>
</div>
</template>
- <div class="memberItem">
- <div class="memberName">retained size<br>(all instances)</div>
- <div class="memberValue">
- <eval-link callback="{{ retainedSize }}"></eval-link>
+
+ <template if="{{ !cls.hasNoAllocations }}">
+ <div class="memberItem">&nbsp;</div>
+ <div class="memberItem">
+ <div class="memberName">current instances</div>
+ <div class="memberValue">
+ {{ cls.newSpace.current.instances + cls.oldSpace.current.instances }}
+ </div>
</div>
- </div>
+ <div class="memberItem">
+ <div class="memberName">shallow size</div>
Cutch 2014/06/20 18:10:49 shallow size (of all instances)?
koda 2014/06/20 18:37:03 I made a "current instances" section instead. See
+ <div class="memberValue">
+ {{ cls.newSpace.current.bytes + cls.oldSpace.current.bytes }}
Cutch 2014/06/20 18:10:49 I think this might double count. I'm not sure the
koda 2014/06/20 18:37:04 I think that's true, and that the correct solution
+ </div>
+ </div>
+ <div class="memberItem">
+ <div class="memberName">retained size</div>
Cutch 2014/06/20 18:10:49 (of all instances)?
koda 2014/06/20 18:37:04 See above.
+ <div class="memberValue">
+ <eval-link callback="{{ retainedSize }}"></eval-link>
+ </div>
+ </div>
+ </template>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698