Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/class_view.html

Issue 345543003: Send allocation stats with each class and show in class view. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <link rel="import" href="../../../../packages/polymer/polymer.html"> 1 <link rel="import" href="../../../../packages/polymer/polymer.html">
2 <link rel="import" href="curly_block.html"> 2 <link rel="import" href="curly_block.html">
3 <link rel="import" href="eval_box.html"> 3 <link rel="import" href="eval_box.html">
4 <link rel="import" href="eval_link.html"> 4 <link rel="import" href="eval_link.html">
5 <link rel="import" href="field_ref.html"> 5 <link rel="import" href="field_ref.html">
6 <link rel="import" href="function_ref.html"> 6 <link rel="import" href="function_ref.html">
7 <link rel="import" href="instance_ref.html"> 7 <link rel="import" href="instance_ref.html">
8 <link rel="import" href="library_ref.html"> 8 <link rel="import" href="library_ref.html">
9 <link rel="import" href="nav_bar.html"> 9 <link rel="import" href="nav_bar.html">
10 <link rel="import" href="observatory_element.html"> 10 <link rel="import" href="observatory_element.html">
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 </template> 79 </template>
80 </div> 80 </div>
81 </div> 81 </div>
82 </template> 82 </template>
83 <template if="{{ cls.name != cls.vmName }}"> 83 <template if="{{ cls.name != cls.vmName }}">
84 <div class="memberItem"> 84 <div class="memberItem">
85 <div class="memberName">vm name</div> 85 <div class="memberName">vm name</div>
86 <div class="memberValue">{{ cls.vmName }}</div> 86 <div class="memberValue">{{ cls.vmName }}</div>
87 </div> 87 </div>
88 </template> 88 </template>
89 <div class="memberItem"> 89
90 <div class="memberName">retained size<br>(all instances)</div> 90 <template if="{{ !cls.hasNoAllocations }}">
91 <div class="memberValue"> 91 <div class="memberItem">&nbsp;</div>
92 <eval-link callback="{{ retainedSize }}"></eval-link> 92 <div class="memberItem">
93 <div class="memberName">current instances</div>
94 <div class="memberValue">
95 {{ cls.newSpace.current.instances + cls.oldSpace.current.instances }}
96 </div>
93 </div> 97 </div>
94 </div> 98 <div class="memberItem">
99 <div class="memberName">shallow size</div>
Cutch 2014/06/20 18:10:49 shallow size (of all instances)?
koda 2014/06/20 18:37:03 I made a "current instances" section instead. See
100 <div class="memberValue">
101 {{ cls.newSpace.current.bytes + cls.oldSpace.current.bytes }}
Cutch 2014/06/20 18:10:49 I think this might double count. I'm not sure the
koda 2014/06/20 18:37:04 I think that's true, and that the correct solution
102 </div>
103 </div>
104 <div class="memberItem">
105 <div class="memberName">retained size</div>
Cutch 2014/06/20 18:10:49 (of all instances)?
koda 2014/06/20 18:37:04 See above.
106 <div class="memberValue">
107 <eval-link callback="{{ retainedSize }}"></eval-link>
108 </div>
109 </div>
110 </template>
95 </div> 111 </div>
96 </div> 112 </div>
97 113
98 <template if="{{ cls.error != null }}"> 114 <template if="{{ cls.error != null }}">
99 <!-- TODO(turnidge): Don't use instance-ref for error display here --> 115 <!-- TODO(turnidge): Don't use instance-ref for error display here -->
100 <instance-ref ref="{{ cls.error }}"></instance-ref> 116 <instance-ref ref="{{ cls.error }}"></instance-ref>
101 </template> 117 </template>
102 118
103 <hr> 119 <hr>
104 120
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 160
145 <div class="content"> 161 <div class="content">
146 <eval-box callback="{{ eval }}"></eval-box> 162 <eval-box callback="{{ eval }}"></eval-box>
147 </div> 163 </div>
148 <br><br><br><br> 164 <br><br><br><br>
149 <br><br><br><br> 165 <br><br><br><br>
150 </template> 166 </template>
151 </polymer-element> 167 </polymer-element>
152 168
153 <script type="application/dart" src="class_view.dart"></script> 169 <script type="application/dart" src="class_view.dart"></script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698