Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: tests/lib/mirrors/immutable_collections_test.dart

Issue 34533003: VM: Always return immutable collections from the mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/object.cc ('K') | « tests/lib/lib.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/immutable_collections_test.dart
diff --git a/tests/lib/mirrors/immutable_collections_test.dart b/tests/lib/mirrors/immutable_collections_test.dart
index 268ebde154dacde4fe34f4f781b63aa3506709bc..391fce449aad0e100c3126465a96ebf75e850a64 100644
--- a/tests/lib/mirrors/immutable_collections_test.dart
+++ b/tests/lib/mirrors/immutable_collections_test.dart
@@ -60,18 +60,21 @@ checkClass(ClassMirror cm) {
cm.typeVariables.forEach(checkTypeVariable);
}
+checkType(TypeMirror tm) {
+ checkList(tm.metadata, 'TypeMirror.metadata');
+}
+
checkLibrary(LibraryMirror lm) {
checkMap(lm.members, 'LibraryMirror.members');
checkMap(lm.variables, 'LibraryMirror.variables');
checkMap(lm.classes, 'LibraryMirror.classes');
- // TODO(rmacnak): Revisit after members hoisted to TypeMirror.
- // checkMap(lm.types, 'LibraryMirror.types');
+ checkMap(lm.types, 'LibraryMirror.types');
checkMap(lm.functions, 'LibraryMirror.functions');
checkMap(lm.getters, 'LibraryMirror.getters');
checkMap(lm.setters, 'LibraryMirror.setters');
checkList(lm.metadata, 'LibraryMirror.metadata');
- // lm.types.forEach(checkType);
+ lm.types.values.forEach(checkType);
lm.classes.values.forEach(checkClass);
lm.functions.values.forEach(checkMethod);
lm.getters.values.forEach(checkMethod);
@@ -81,6 +84,6 @@ checkLibrary(LibraryMirror lm) {
main() {
currentMirrorSystem().libraries.values.forEach(checkLibrary);
- // checkType(currentMirrorSystem().voidType);
- // checkType(currentMirrorSystem().dynamicType);
+ checkType(currentMirrorSystem().voidType);
+ checkType(currentMirrorSystem().dynamicType);
}
« runtime/vm/object.cc ('K') | « tests/lib/lib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698