Issue 3452026: Attempt at fixing SSLUITest.TestUnsafeContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3452026: Attempt at fixing SSLUITest.TestUnsafeContents (Closed)

Created:
10 years, 3 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

The original intent of the test was to test badd HTTPS sub-resources inside a good HTTPS page. Somehow it got changed to bad HTTPS in HTTP, but the test was still retrieving the URL from the HTTPS server (which was not running) causing the sub-resource not be found. I looked quickly to see if we could catch calls to GetURL on a non-started server (so we could DCHECK) but there does not seem to be an immediate way to do that. BUG=40932 TEST=Run the test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60722

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ssl/ssl_browser_tests.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

10 years, 2 months ago (2010-09-27 08:53:00 UTC) #2

LGTM

Sorry, I broke this during TestServer changes. Good catch.

Expand Messages | Collapse Messages

Issue 3452026: Attempt at fixing SSLUITest.TestUnsafeContents (Closed)

Description

Patch Set 1 #

Patch Set 2 : Attempt at fixing SSLUITest #

Patch Set 3 : Synced #

Messages