Chromium Code Reviews
Help | Chromium Project | Sign in

Issue 3452026: Attempt at fixing SSLUITest.TestUnsafeContents (Closed)

Can't Edit
Can't Publish+Mail
Start Review
5 years ago by Jay Civelli
4 years, 5 months ago
Paweł Hajdan Jr.
Base URL:


The original intent of the test was to test badd HTTPS sub-resources inside a good HTTPS page. Somehow it got changed to bad HTTPS in HTTP, but the test was still retrieving the URL from the HTTPS server (which was not running) causing the sub-resource not be found. I looked quickly to see if we could catch calls to GetURL on a non-started server (so we could DCHECK) but there does not seem to be an immediate way to do that. BUG=40932 TEST=Run the test Committed:

Patch Set 1 #

Patch Set 2 : Attempt at fixing SSLUITest #

Patch Set 3 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ssl/ View 1 2 1 chunk +1 line, -1 line 0 comments Download
Project "None" does not have a commit queue.


Total messages: 2 (0 generated)
Jay Civelli
5 years ago (2010-09-25 01:27:45 UTC) #1
Paweł Hajdan Jr.
5 years ago (2010-09-27 08:53:00 UTC) #2

Sorry, I broke this during TestServer changes. Good catch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 6d3bdde