Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 3452026: Attempt at fixing SSLUITest.TestUnsafeContents (Closed)

Created:
7 years, 1 month ago by Jay Civelli
Modified:
6 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

The original intent of the test was to test badd HTTPS sub-resources inside a good HTTPS page. Somehow it got changed to bad HTTPS in HTTP, but the test was still retrieving the URL from the HTTPS server (which was not running) causing the sub-resource not be found. I looked quickly to see if we could catch calls to GetURL on a non-started server (so we could DCHECK) but there does not seem to be an immediate way to do that. BUG=40932 TEST=Run the test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60722

Patch Set 1 #

Patch Set 2 : Attempt at fixing SSLUITest #

Patch Set 3 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jay Civelli
7 years, 1 month ago (2010-09-25 01:27:45 UTC) #1
Paweł Hajdan Jr.
7 years, 1 month ago (2010-09-27 08:53:00 UTC) #2
LGTM

Sorry, I broke this during TestServer changes. Good catch.

Powered by Google App Engine
This is Rietveld efc10ee0f