Chromium Code Reviews
Help | Chromium Project | Sign in
(494)

Issue 3452026: Attempt at fixing SSLUITest.TestUnsafeContents (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by Jay Civelli
Modified:
2 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

The original intent of the test was to test badd HTTPS sub-resources inside a good HTTPS page.
Somehow it got changed to bad HTTPS in HTTP, but the test was still retrieving the URL from the HTTPS server (which was not running) causing the sub-resource not be found.
I looked quickly to see if we could catch calls to GetURL on a non-started server (so we could DCHECK) but there does not seem to be an immediate way to do that.

BUG=40932
TEST=Run the test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60722

Patch Set 1 #

Patch Set 2 : Attempt at fixing SSLUITest #

Patch Set 3 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Lint Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 1 chunk +1 line, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 2
Jay Civelli
3 years, 6 months ago #1
Paweł Hajdan Jr.
3 years, 6 months ago #2
LGTM

Sorry, I broke this during TestServer changes. Good catch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434