Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345043002: Remove virtual/serviceworker test suite (Closed)

Created:
6 years, 6 months ago by falken
Modified:
6 years, 6 months ago
Reviewers:
jsbell
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove virtual/serviceworker test suite It's no longer needed because --enable-service-worker has been removed. This patch also removes passing expectation files for W3C harness tests, no longer needed after https://codereview.chromium.org/328243002 BUG=365201 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -297 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/activation-after-registration-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/controller-on-load-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/controller-on-reload-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/fetch-event-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/fetch-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/headermap-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/indexeddb-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/interfaces-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/postmessage-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/postmessage-msgport-to-client-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/postmessage-to-client-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/ready-controlled-document-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/registration-end-to-end-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/registration-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/registration-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/request-end-to-end-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/request-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/response-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/service-worker-gc-expected.txt View 1 chunk +6 lines, -1 line 0 comments Download
D LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/serviceworkerobject-scope-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/state-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/unregister-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/waiting-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/window-close-during-registration-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/activation-after-registration-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/controller-on-load-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/controller-on-reload-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/fetch-event-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/fetch-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/headermap-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/indexeddb-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/interfaces-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/postmessage-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/postmessage-msgport-to-client-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/postmessage-to-client-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/ready-controlled-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/registration-end-to-end-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/registration-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/registration-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/request-end-to-end-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/request-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/response-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/service-worker-gc-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/serviceworkerglobalscope-scope-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/serviceworkerobject-scope-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/state-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/unregister-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/waiting-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/window-close-during-registration-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
This patch requires https://codereview.chromium.org/339973003/
6 years, 6 months ago (2014-06-20 07:21:12 UTC) #1
jsbell
lgtm
6 years, 6 months ago (2014-06-21 00:12:53 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 6 months ago (2014-06-21 00:20:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/345043002/1
6 years, 6 months ago (2014-06-21 00:21:08 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 03:26:07 UTC) #5
Message was sent while issue was closed. 
Change committed as 176672

Powered by Google App Engine
This is Rietveld 408576698