Notify the browser when the page lost interest about gamepads

Notify the browser when the page lost interest about gamepads

The page visibility logic used in NavigatorGamepad via DeviceEventControllerBase
assumes that we only want to tell the dispatcher that we are uninterested in
events if we have an event listener. This is not perfect for gamepad. If the
page doesn't add event listener for gamepad events it can still poll the data
via navigator.getGamepads() at which point we tell the browser that we need
gamepad data. We also want to tell the browser if we are not interested so that
it can suspend the polling thread.
Long story short, we shouldn't check m_hasEventListener in
pageVisibilityChanged. This CL doesn't change visible behavior thus no tests.
Visibility related tests should be added for gamepad though, I will do that
later.

BUG=386846
R=bajones@chromium.org
TBR=abarth@chromium.org

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176618

[abarth-chromium, 2014-06-20 00:18:04]

lgtm

[kbalazs, 2014-06-20 13:42:15]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-06-20 13:43:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/345013002/1

[commit-bot: I haz the power, 2014-06-20 14:54:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-20 15:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 15:40:58]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[kbalazs, 2014-06-20 15:43:35]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-06-20 15:44:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/345013002/1

[commit-bot: I haz the power, 2014-06-20 15:45:04]

Change committed as 176618

[jamesr, 2014-06-20 19:09:17]

I suspect this patch is causing crashes on a few content_browsertests:

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/374...

RenderViewImplTest.ReloadWhileSwappedOut (run #1):
[ RUN      ] RenderViewImplTest.ReloadWhileSwappedOut
[10056:10056:0620/094310:3359978451:WARNING:resource_bundle.cc(286)]
locale_file_path.empty()
Received signal 11 SEGV_MAPERR 000000000340
#0 0x000000b1076e base::debug::StackTrace::StackTrace()
#1 0x000000b10988 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fd47d1c1cb0 \u003Cunknown>
#3 0x000000749fe3
content::RendererWebKitPlatformSupportImpl::setGamepadListener()
#4 0x0000030cf1cc WebCore::DeviceEventDispatcherBase::addController()
#5 0x0000030cec6a WebCore::DeviceEventControllerBase::startUpdating()
#6 0x000001efbb82 WebCore::Page::setVisibilityState()
#7 0x0000019afff7 blink::WebViewImpl::setVisibilityState()
#8 0x0000007159bc content::RenderFrameImpl::OnNavigate()
#9 0x0000005eb7b0
content::RenderViewImplTest_ReloadWhileSwappedOut_Test::TestBody()
#10 0x000000a458ba testing::Test::Run()
#11 0x000000a4597a testing::TestInfo::Run()
#12 0x000000a45abf testing::TestCase::Run()
#13 0x000000a45d4f testing::internal::UnitTestImpl::RunAllTests()
#14 0x000000a3ff33 testing::UnitTest::Run()
#15 0x000000916c8e base::TestSuite::Run()
#16 0x0000008824b0 content::ContentTestLauncherDelegate::RunTestSuite()
#17 0x0000008fbd4c content::LaunchTests()
#18 0x00000044298b main
#19 0x7fd47bfab76d __libc_start_main
#20 0x00000044373d \u003Cunknown>
  r8: 00001bad83466b70  r9: 0000000000000000 r10: 0000000000000000 r11:
00007fd47c10dc10
 r12: 00000dd806c08500 r13: 00001bad83353780 r14: 0000000000000000 r15:
00001bad8349ec20
  di: 0000000000000015  si: 00001bad83472520  bp: 0000000000000000  bx:
00001bad83472520
  dx: 00007fd48103cde0  ax: 0000000000000000  cx: 00001bad83479920  sp:
00007fff566b8d70
  ip: 0000000000749fe3 efl: 0000000000010246 cgf: 0000000000000033 erf:
0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000340

[jamesr, 2014-06-20 19:10:12]

A revert of this CL has been created in
https://codereview.chromium.org/348083003/ by jamesr@chromium.org.

The reason for reverting is: Causing content_browsertest crashes on all
platforms.