Issue 344773002: Revert 278198 "Remove NPAPI plugin from chromoting webapp."

Issue 344773002: Revert 278198 "Remove NPAPI plugin from chromoting webapp." (Closed)

Created:
6 years, 6 months ago by amineer_google

Modified:
6 years, 6 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2058/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert 278198 "Remove NPAPI plugin from chromoting webapp." Reverting this on branch only, may have caused compile failure. Logs: http://master.chrome.corp.google.com:8010/builders/precise32/builds/1668/steps/runhooks/logs/stdio > Remove NPAPI plugin from chromoting webapp. > > BUG=134215 > R=weitaosu@chromium.org, wez@chromium.org > > Review URL: https://codereview.chromium.org/342583002 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278257

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+742 lines, -26 lines)			Patch
M	remoting/branding_Chrome	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/branding_Chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/branding.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/chromoting_host_context.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	remoting/host/plugin/host_log_handler.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_log_handler.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin.def	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin-Info.plist	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin-InfoPlist.strings.jinja2	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin_utils.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin_utils.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_script_object.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_script_object.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	remoting/host/win/version.rc.jinja2	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	remoting/remoting.gyp	View	3 chunks	+33 lines, -2 lines	0 comments	Download
M	remoting/remoting_client.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/remoting_host.gypi	View	2 chunks	+101 lines, -0 lines	0 comments	Download
M	remoting/remoting_host_linux.gypi	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	remoting/remoting_host_mac.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/remoting_webapp.gypi	View	5 chunks	+27 lines, -0 lines	0 comments	Download
M	remoting/resources/remoting_strings.grd	View	5 chunks	+11 lines, -2 lines	0 comments	Download
M	remoting/webapp/build-webapp.py	View	3 chunks	+52 lines, -7 lines	0 comments	Download
M	remoting/webapp/host_controller.js	View	3 chunks	+37 lines, -1 line	0 comments	Download
M	remoting/webapp/host_dispatcher.js	View	24 chunks	+214 lines, -4 lines	0 comments	Download
M	remoting/webapp/host_it2me_dispatcher.js	View	6 chunks	+80 lines, -8 lines	0 comments	Download
M	remoting/webapp/host_screen.js	View	2 chunks	+17 lines, -3 lines	0 comments	Download
M	remoting/webapp/host_session.js	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	remoting/webapp/js_proto/remoting_proto.js	View	1 chunk	+129 lines, -0 lines	0 comments	Download
M	remoting/webapp/plugin_settings.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	remoting/webapp/remoting.js	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amineer_google

6 years, 6 months ago (2014-06-19 03:49:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r278257 (tree was closed).

Expand Messages | Collapse Messages