Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 342583002: Remove NPAPI plugin from chromoting webapp. (Closed)

Created:
6 years, 6 months ago by Sergey Ulanov
Modified:
6 years, 6 months ago
Reviewers:
weitao, Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3118 lines) Patch
M remoting/branding_Chrome View 1 chunk +1 line, -1 line 0 comments Download
M remoting/branding_Chromium View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/branding.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host_context.h View 1 chunk +1 line, -2 lines 0 comments Download
D remoting/host/plugin/host_log_handler.h View 1 chunk +0 lines, -38 lines 0 comments Download
D remoting/host/plugin/host_log_handler.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D remoting/host/plugin/host_plugin.cc View 1 chunk +0 lines, -574 lines 0 comments Download
D remoting/host/plugin/host_plugin.def View 1 chunk +0 lines, -6 lines 0 comments Download
D remoting/host/plugin/host_plugin-Info.plist View 1 chunk +0 lines, -29 lines 0 comments Download
D remoting/host/plugin/host_plugin-InfoPlist.strings.jinja2 View 1 chunk +0 lines, -3 lines 0 comments Download
D remoting/host/plugin/host_plugin_utils.h View 1 chunk +0 lines, -55 lines 0 comments Download
D remoting/host/plugin/host_plugin_utils.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D remoting/host/plugin/host_script_object.h View 1 chunk +0 lines, -320 lines 0 comments Download
D remoting/host/plugin/host_script_object.cc View 1 chunk +0 lines, -1143 lines 0 comments Download
M remoting/host/win/version.rc.jinja2 View 2 chunks +1 line, -6 lines 0 comments Download
M remoting/remoting.gyp View 3 chunks +2 lines, -33 lines 0 comments Download
M remoting/remoting_client.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_host.gypi View 2 chunks +0 lines, -101 lines 0 comments Download
M remoting/remoting_host_linux.gypi View 2 chunks +3 lines, -6 lines 0 comments Download
M remoting/remoting_host_mac.gypi View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_webapp.gypi View 5 chunks +0 lines, -27 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 1 2 5 chunks +2 lines, -11 lines 0 comments Download
M remoting/webapp/build-webapp.py View 3 chunks +7 lines, -52 lines 0 comments Download
M remoting/webapp/host_controller.js View 3 chunks +1 line, -37 lines 0 comments Download
M remoting/webapp/host_dispatcher.js View 23 chunks +4 lines, -214 lines 0 comments Download
M remoting/webapp/host_it2me_dispatcher.js View 6 chunks +8 lines, -80 lines 0 comments Download
M remoting/webapp/host_screen.js View 2 chunks +3 lines, -17 lines 0 comments Download
M remoting/webapp/host_session.js View 1 chunk +0 lines, -8 lines 0 comments Download
M remoting/webapp/js_proto/remoting_proto.js View 1 1 chunk +0 lines, -129 lines 0 comments Download
M remoting/webapp/plugin_settings.js View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/webapp/remoting.js View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Sergey Ulanov
6 years, 6 months ago (2014-06-17 22:53:54 UTC) #1
weitao
On 2014/06/17 22:53:54, Sergey Ulanov wrote: Could you please also remove the plugin related declaration ...
6 years, 6 months ago (2014-06-17 23:10:27 UTC) #2
Sergey Ulanov
On 2014/06/17 23:10:27, weitaosu wrote: > Could you please also remove the plugin related declaration ...
6 years, 6 months ago (2014-06-17 23:15:31 UTC) #3
weitao
https://codereview.chromium.org/342583002/diff/20001/remoting/webapp/host_it2me_dispatcher.js File remoting/webapp/host_it2me_dispatcher.js (right): https://codereview.chromium.org/342583002/diff/20001/remoting/webapp/host_it2me_dispatcher.js#newcode10 remoting/webapp/host_it2me_dispatcher.js:10: * TODO(sergeyu): Remove this class. Do you plan to ...
6 years, 6 months ago (2014-06-17 23:20:02 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/342583002/diff/20001/remoting/webapp/host_it2me_dispatcher.js File remoting/webapp/host_it2me_dispatcher.js (right): https://codereview.chromium.org/342583002/diff/20001/remoting/webapp/host_it2me_dispatcher.js#newcode10 remoting/webapp/host_it2me_dispatcher.js:10: * TODO(sergeyu): Remove this class. On 2014/06/17 23:20:02, weitaosu ...
6 years, 6 months ago (2014-06-17 23:30:01 UTC) #5
weitao
LGTM.
6 years, 6 months ago (2014-06-18 00:31:39 UTC) #6
Wez
LGTM * (10**8) https://codereview.chromium.org/342583002/diff/20001/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/342583002/diff/20001/remoting/resources/remoting_strings.grd#newcode217 remoting/resources/remoting_strings.grd:217: <message desc="Error displayed if the host ...
6 years, 6 months ago (2014-06-18 00:43:12 UTC) #7
Sergey Ulanov
https://codereview.chromium.org/342583002/diff/20001/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/342583002/diff/20001/remoting/resources/remoting_strings.grd#newcode217 remoting/resources/remoting_strings.grd:217: <message desc="Error displayed if the host or client plugin ...
6 years, 6 months ago (2014-06-18 19:45:09 UTC) #8
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 6 months ago (2014-06-18 19:45:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/342583002/40001
6 years, 6 months ago (2014-06-18 19:46:29 UTC) #10
Sergey Ulanov
Committed patchset #3 manually as r278198 (presubmit successful).
6 years, 6 months ago (2014-06-18 23:49:55 UTC) #11
please use gerrit instead
6 years, 6 months ago (2014-06-19 00:48:25 UTC) #12
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/340993002/ by rouslan@chromium.org.

The reason for reverting is: Broke "gclient runhooks" on
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%...

gyp: Undefined variable plugin_file in
/b/build/slave/google-chrome-rel-linux_64/build/src/remoting/remoting.gyp.

Powered by Google App Engine
This is Rietveld 408576698