Issue 344763004: Fixs bug where keyevents weren't created correctly on X

Issue 344763004: Fixs bug where keyevents weren't created correctly on X (Closed)

Created:
6 years, 6 months ago by sky

Modified:
6 years, 6 months ago

Reviewers:
darin (slow to review), Ben Goodger (Google)

CC:
chromium-reviews, tdanderson+views_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixs bug where keyevents weren't created correctly on X This resulted in incorrect processing and things like entering not working. BUG=386256 TEST=none R=ben@chromium.org, darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278369

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/services/native_viewport/native_viewport_x11.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM https://codereview.chromium.org/344763004/diff/1/mojo/services/native_viewport/native_viewport_x11.cc File mojo/services/native_viewport/native_viewport_x11.cc (right): https://codereview.chromium.org/344763004/diff/1/mojo/services/native_viewport/native_viewport_x11.cc#newcode135 mojo/services/native_viewport/native_viewport_x11.cc:135: ui::KeyEvent key_event(event, false); heh, I have this in ...

6 years, 6 months ago (2014-06-19 05:12:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/344763004/1

6 years, 6 months ago (2014-06-19 14:40:00 UTC) #5

sky

6 years, 6 months ago (2014-06-19 15:00:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r278369 (presubmit successful).

Expand Messages | Collapse Messages