mojo/services/native_viewport/native_viewport_x11.cc - Issue 344763004: Fixs bug where keyevents weren't created correctly on X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/native_viewport/native_viewport_x11.cc

Issue 344763004: Fixs bug where keyevents weren't created correctly on X (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/native_viewport/native_viewport_x11.cc

diff --git a/mojo/services/native_viewport/native_viewport_x11.cc b/mojo/services/native_viewport/native_viewport_x11.cc

index b3db2e8682e9cc2e988bf0c7907560cdd85b43fa..f1b4863529c1d718ac4d66188d5d9c299a0b33c6 100644

--- a/mojo/services/native_viewport/native_viewport_x11.cc

+++ b/mojo/services/native_viewport/native_viewport_x11.cc

@@ -132,7 +132,7 @@ class NativeViewportX11 : public NativeViewport,

if (protocol == atom_wm_delete_window_)

delegate_->OnDestroyed();

} else if (event->type == KeyPress || event->type == KeyRelease) {

- ui::KeyEvent key_event(event, true);

+ ui::KeyEvent key_event(event, false);

darin (slow to review) 2014/06/19 05:12:15 heh, I have this in my tree too!

delegate_->OnEvent(&key_event);

} else if (event->type == ButtonPress || event->type == ButtonRelease ||

event->type == MotionNotify) {

« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/desktop_native_widget_aura.cc » ('j') | no next file with comments »