Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 344693002: Add [TreatReturnedNullStringAs] support for ScalarValueString (Closed)

Created:
6 years, 6 months ago by jsbell
Modified:
6 years, 6 months ago
Reviewers:
haraken, horo
CC:
blink-reviews, watchdog-blink-watchlist_google.com, blink-reviews-bindings_chromium.org, arv+blink, Inactive, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Add [TreatReturnedNullStringAs] support for ScalarValueString Copy/Paste&Find/Replace of r176370 - same thing for ByteString. Not strictly needed by any existing IDLs, but trivial code change, and no code size difference until used. R=horo@chromium.org,haraken@chromium.org BUG=379009 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -1 line) Patch
M LayoutTests/fast/js/webidl-type-mapping.html View 2 chunks +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/webidl-type-mapping-expected.txt View 2 chunks +20 lines, -0 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 4 chunks +90 lines, -0 lines 0 comments Download
M Source/core/testing/TypeConversions.idl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
I don't know if this is worth landing, but it won't hurt. If we do ...
6 years, 6 months ago (2014-06-18 20:58:17 UTC) #1
haraken
LGTM. It's a good thing to make the behavior of DOMString, ByteString and ScalarValueString consistent.
6 years, 6 months ago (2014-06-18 23:24:46 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-19 00:01:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/344693002/1
6 years, 6 months ago (2014-06-19 00:01:50 UTC) #4
horo
lgtm
6 years, 6 months ago (2014-06-19 01:26:58 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 02:04:23 UTC) #6
Message was sent while issue was closed.
Change committed as 176477

Powered by Google App Engine
This is Rietveld 408576698