Source/bindings/scripts/v8_types.py - Issue 344693002: Add [TreatReturnedNullStringAs] support for ScalarValueString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 344693002: Add [TreatReturnedNullStringAs] support for ScalarValueString (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 590ce6adc47c2e786ea021e03fd9684b02bc387e..c6ee255d53249f1d53dcc8701952e20e532ad295 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -550,7 +550,7 @@ def v8_conversion_type(idl_type, extended_attributes):

return 'int'

if base_idl_type in CPP_UNSIGNED_TYPES:

return 'unsigned'

- if base_idl_type in ('DOMString', 'ByteString'):

+ if base_idl_type in ('DOMString', 'ByteString', 'ScalarValueString'):

if 'TreatReturnedNullStringAs' not in extended_attributes:

return base_idl_type

treat_returned_null_string_as = extended_attributes['TreatReturnedNullStringAs']