[reland] views: Move MenuButton from TextButton to LabelButton.

[reland] views: Move MenuButton from TextButton to LabelButton.

[This reland also fixes an issue with the label drawn on top of the old
profile switching menu. It also expands ExtensionApiTest.Bookmarks
disabling from just Windows to Windows and Linux.]

This also converts the TextButtons in the BookmarkBarView to
LabelButtons, since they need to have the same base class as MenuButton
does. This also standardizes on fade eliding instead of fade eliding
sometimes and ellipsis eliding in other cases.

This patch has the effect that everything on the bookmark bar also
renders with GTK+ borders in GTK theme mode on Linux.

BUG=155363, 331924, 385934, 383452
R=msw@chromium.org, noms@chromium.org
TBR=msw@chromium.org, sky@chromium.org
First Review URL: https://codereview.chromium.org/298813002

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278156

[Elliot Glaysher, 2014-06-18 18:13:12]

This patch also rolls in the fix from https://codereview.chromium.org/341733002/
, which didn't land because trybot flake.

[msw, 2014-06-18 18:22:55]

On 2014/06/18 18:13:12, Elliot Glaysher wrote:
> This patch also rolls in the fix from
https://codereview.chromium.org/341733002/
> , which didn't land because trybot flake.

It's helpful to reviewers if you upload the first patch as the CL that was
reverted, then upload another patch set with the additional fixes, so we can
more easily review the differences from the prior CL. Also, bummer about
disabling the tests; we really need to go back and fix and re-enable tests more
often, it's sad to see so many disabled and ignored indefinitely.

Please add to the BUG= the test failure bugs so the owners are made aware that
additional platforms are being disabled. I guess the bugs are: 331924
(DetachToBrowserTabDragControllerTest.DragDirectlyToSecondWindow) and 331924
(ExtensionApiTest.Bookmarks)

Shrug, lgtm.

[noms (inactive), 2014-06-18 19:16:14]

lgtm, but I have no powers :)

[Evan Stade, 2014-06-18 20:24:29]

https://codereview.chromium.org/344643002/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/344643002/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:1801:
GetBookmarkButton(i)->SetTextColor(views::Button::STATE_NORMAL, color);
why isn't this done in MenuButton::OnThemeChanged()?

[Elliot Glaysher, 2014-06-18 20:31:02]

Committed patchset #1 manually as r278156 (presubmit successful).