chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc - Issue 344643002: [reland] views: Move MenuButton from TextButton to LabelButton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

Issue 344643002: [reland] views: Move MenuButton from TextButton to LabelButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

diff --git a/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc b/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

index ed69780848c15d7671ebb3c2590383c8ff174c42..45e55d696bfeabeef4b85f4f16edb79cd4d932fb 100644

--- a/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

+++ b/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

@@ -44,8 +44,8 @@ void BrowserActionTestUtil::InspectPopup(int index) {

}

bool BrowserActionTestUtil::HasIcon(int index) {

- return GetContainer(browser_)->GetBrowserActionViewAt(index)->button()->

- HasIcon();

+ return !GetContainer(browser_)->GetBrowserActionViewAt(index)->button()->

+ GetImage(views::Button::STATE_NORMAL).isNull();

}

gfx::Image BrowserActionTestUtil::GetIcon(int index) {