components/gcm_driver/gcm_stats_recorder_impl.h - Issue 344613003: Record GCM received data message intervals in UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl.h

Issue 344613003: Record GCM received data message intervals in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Jian's and Filip's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/gcm_driver/gcm_stats_recorder_impl.h

diff --git a/components/gcm_driver/gcm_stats_recorder_impl.h b/components/gcm_driver/gcm_stats_recorder_impl.h

index 4c3c57ec55ab69f7cbf58ce778c91353c4c65fb7..635a832adf572d593bb18ce2971494f0fd699cdd 100644

--- a/components/gcm_driver/gcm_stats_recorder_impl.h

+++ b/components/gcm_driver/gcm_stats_recorder_impl.h

@@ -147,6 +147,8 @@ class GCMStatsRecorderImpl : public GCMStatsRecorder {

std::deque<ReceivingActivity> receiving_activities_;

std::deque<SendingActivity> sending_activities_;

+ int64 last_data_message_received_timestamp_;

fgorski 2014/07/16 04:11:11 use base::Time Consider renaming to: last_data_me

juyik 2014/07/16 17:49:24 Done.

DISALLOW_COPY_AND_ASSIGN(GCMStatsRecorderImpl);

};