components/gcm_driver/gcm_stats_recorder_impl.h - Issue 344613003: Record GCM received data message intervals in UMA

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/gcm_driver/gcm_stats_recorder_impl.h

Issue 344613003: Record GCM received data message intervals in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Jian's and Filip's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_IMPL_H_	5 #ifndef COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_IMPL_H_

6 #define COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_IMPL_H_	6 #define COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_IMPL_H_

7	7

8 #include <deque>	8 #include <deque>

9 #include <string>	9 #include <string>

10 #include <vector>	10 #include <vector>

(...skipping 129 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
140	140

141 bool is_recording_;	141 bool is_recording_;

142 Delegate* delegate_;	142 Delegate* delegate_;

143	143

144 std::deque<CheckinActivity> checkin_activities_;	144 std::deque<CheckinActivity> checkin_activities_;

145 std::deque<ConnectionActivity> connection_activities_;	145 std::deque<ConnectionActivity> connection_activities_;

146 std::deque<RegistrationActivity> registration_activities_;	146 std::deque<RegistrationActivity> registration_activities_;

147 std::deque<ReceivingActivity> receiving_activities_;	147 std::deque<ReceivingActivity> receiving_activities_;

148 std::deque<SendingActivity> sending_activities_;	148 std::deque<SendingActivity> sending_activities_;

149	149

	150 int64 last_data_message_received_timestamp_;
	fgorski 2014/07/16 04:11:11 use base::Time Consider renaming to: last_data_me use base::Time Consider renaming to: last_data_message_burst_start_time_ juyik 2014/07/16 17:49:24 Done. Show quoted text On 2014/07/16 04:11:11, fgorski wrote: > use base::Time > > Consider renaming to: last_data_message_burst_start_time_ Done.
	151

150 DISALLOW_COPY_AND_ASSIGN(GCMStatsRecorderImpl);	152 DISALLOW_COPY_AND_ASSIGN(GCMStatsRecorderImpl);

151 };	153 };

152	154

153 } // namespace gcm	155 } // namespace gcm

154	156

155 #endif // COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_IMPL_H_	157 #endif // COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_IMPL_H_

OLD	NEW

« no previous file with comments | « no previous file | components/gcm_driver/gcm_stats_recorder_impl.cc » ('j') | components/gcm_driver/gcm_stats_recorder_impl.cc » ('J')