Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 344583002: Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector (Relanding) (Closed)

Created:
6 years, 6 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org, rkc, DaleCurtis
Project:
chromium
Visibility:
Public.

Description

Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector (Relanding). Second attempt to land https://codereview.chromium.org/314713002/ which has been reverted. TBR=dalecurtis BUG=375155 TEST=WebRTC and WebSpeech demos Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278345

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Fixes Chrome OS build error #

Patch Set 4 : Added extra non-pure OnData API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -288 lines) Patch
M content/browser/media/capture/web_contents_audio_input_stream_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer.h View 3 chunks +16 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer.cc View 3 chunks +31 lines, -12 lines 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognizer_impl.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl_unittest.cc View 13 chunks +29 lines, -22 lines 0 comments Download
M media/audio/agc_audio_stream.h View 3 chunks +0 lines, -4 lines 0 comments Download
M media/audio/alsa/alsa_input.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/alsa/alsa_input.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M media/audio/android/audio_android_unittest.cc View 5 chunks +21 lines, -15 lines 0 comments Download
M media/audio/android/audio_record_input.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/audio/android/audio_record_input.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M media/audio/android/opensles_input.h View 2 chunks +3 lines, -0 lines 0 comments Download
M media/audio/android/opensles_input.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M media/audio/audio_input_controller.h View 5 chunks +11 lines, -12 lines 0 comments Download
M media/audio/audio_input_controller.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M media/audio/audio_input_controller_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M media/audio/audio_input_device.cc View 5 chunks +21 lines, -13 lines 0 comments Download
M media/audio/audio_input_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/audio_io.h View 1 2 3 1 chunk +12 lines, -3 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M media/audio/cras/cras_input.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/cras/cras_input.cc View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M media/audio/cras/cras_input_unittest.cc View 1 2 3 2 chunks +3 lines, -8 lines 0 comments Download
M media/audio/fake_audio_input_stream.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/audio/fake_audio_input_stream.cc View 4 chunks +13 lines, -6 lines 0 comments Download
M media/audio/mac/audio_input_mac.h View 2 chunks +3 lines, -0 lines 0 comments Download
M media/audio/mac/audio_input_mac.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac_unittest.cc View 5 chunks +17 lines, -18 lines 0 comments Download
M media/audio/pulse/pulse_input.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/pulse/pulse_input.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M media/audio/pulse/pulse_output.h View 2 chunks +3 lines, -0 lines 0 comments Download
M media/audio/pulse/pulse_output.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M media/audio/virtual_audio_input_stream.cc View 1 chunk +1 line, -8 lines 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 13 chunks +35 lines, -25 lines 0 comments Download
M media/audio/win/wavein_input_win.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/audio/win/wavein_input_win.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M media/base/audio_bus.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
henrika (OOO until Aug 14)
Committed patchset #4 manually as r278345 (presubmit successful).
6 years, 6 months ago (2014-06-19 12:39:27 UTC) #1
no longer working on chromium
6 years, 6 months ago (2014-06-19 12:46:50 UTC) #2
Message was sent while issue was closed.
On 2014/06/19 12:39:27, henrika (OOO June 23-July 7) wrote:
> Committed patchset #4 manually as r278345 (presubmit successful).

lgtm and thanks for the offline explaination :) hope it stays.

Powered by Google App Engine
This is Rietveld 408576698