Issue 344513005: Revert "Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but inste…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344513005: Revert "Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but inste… (Closed)

Created:
6 years, 6 months ago by hirono

Modified:
6 years, 6 months ago

Reviewers:
Mike Lerman

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but instead successfully completes the reconciliation." (https://codereview.chromium.org/309843002/) The original CL causes crashes about 20 secs after launching the linux build of chromeos. This reverts commit 660a4d00c835a21b6972647df37e75f4e22f8d73. Conflicts: chrome/browser/signin/account_reconcilor_unittest.cc Original issue's description: > Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but instead successfully completes the reconciliation. > Improve the UMAHistogramHelper so that it can nicely take snapshots between tests, allowing the test writer to easily test ONLY the changes logged in "this" test. > Write a new unit test that executes the reconcilor twice, and make all reconcilor unit tests execute with and without the flag. > > BUG=357693 > TBR=phajdan.jr@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277605 BUG=357693, 386045 TEST=None TBR=mlerman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277990

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -257 lines)			Patch
M	base/test/statistics_delta_reader.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/signin/account_reconcilor_unittest.cc	View	17 chunks	+12 lines, -164 lines	0 comments	Download
M	chrome/test/base/uma_histogram_helper.h	View	3 chunks	+3 lines, -23 lines	0 comments	Download
M	chrome/test/base/uma_histogram_helper.cc	View	2 chunks	+4 lines, -32 lines	0 comments	Download
M	components/signin/core/browser/account_reconcilor.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	components/signin/core/browser/account_reconcilor.cc	View	6 chunks	+16 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/344513005/1

6 years, 6 months ago (2014-06-18 07:18:26 UTC) #2

hirono

6 years, 6 months ago (2014-06-18 08:40:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r277990 (presubmit successful).

Expand Messages | Collapse Messages