Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: base/test/statistics_delta_reader.h

Issue 344513005: Revert "Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but inste… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/signin/account_reconcilor_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TEST_STATISTICS_DELTA_READER_H_ 5 #ifndef BASE_TEST_STATISTICS_DELTA_READER_H_
6 #define BASE_TEST_STATISTICS_DELTA_READER_H_ 6 #define BASE_TEST_STATISTICS_DELTA_READER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 13
14 namespace base { 14 namespace base {
15 15
16 class HistogramSamples; 16 class HistogramSamples;
17 17
18 // This class acts as a differential reader for histogram samples, enabling 18 // This class acts as a differential reader for histogram samples, enabling
19 // tests to check that metrics were recorded as they should be. 19 // tests to check that metrics were recorded as they should be.
20 //
21 // This class is DEPRECATED.
22 // TODO(mlerman): Remove all references to this class with UMAHistogramHelper
23 // references. crbug.com/384011
24 class StatisticsDeltaReader { 20 class StatisticsDeltaReader {
25 public: 21 public:
26 StatisticsDeltaReader(); 22 StatisticsDeltaReader();
27 ~StatisticsDeltaReader(); 23 ~StatisticsDeltaReader();
28 24
29 // Returns the histogram data accumulated since this instance was created. 25 // Returns the histogram data accumulated since this instance was created.
30 // Returns NULL if no samples are available. 26 // Returns NULL if no samples are available.
31 scoped_ptr<HistogramSamples> GetHistogramSamplesSinceCreation( 27 scoped_ptr<HistogramSamples> GetHistogramSamplesSinceCreation(
32 const std::string& histogram_name); 28 const std::string& histogram_name);
33 29
34 private: 30 private:
35 // Used to determine the histogram changes made during this instance's 31 // Used to determine the histogram changes made during this instance's
36 // lifecycle. This instance takes ownership of the samples, which are deleted 32 // lifecycle. This instance takes ownership of the samples, which are deleted
37 // when the instance is destroyed. 33 // when the instance is destroyed.
38 std::map<std::string, HistogramSamples*> original_samples_; 34 std::map<std::string, HistogramSamples*> original_samples_;
39 35
40 DISALLOW_COPY_AND_ASSIGN(StatisticsDeltaReader); 36 DISALLOW_COPY_AND_ASSIGN(StatisticsDeltaReader);
41 }; 37 };
42 38
43 } // namespace base 39 } // namespace base
44 40
45 #endif // BASE_TEST_STATISTICS_DELTA_READER_H_ 41 #endif // BASE_TEST_STATISTICS_DELTA_READER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/signin/account_reconcilor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698