Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 344513004: Fix a potential overflow in SortedListBSearch (Closed)

Created:
6 years, 6 months ago by jianghua
Modified:
6 years, 6 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fix a potential overflow in SortedListBSearch R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21960

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : optimize Deoptimizer::GetOutputInfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M src/deoptimizer.cc View 1 1 chunk +10 lines, -7 lines 0 comments Download
M src/full-codegen.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/utils.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jianghua
6 years, 6 months ago (2014-06-18 03:48:33 UTC) #1
Yang
On 2014/06/18 03:48:33, jianghua.yjh wrote: I don't think this actually ever happens in V8. Maybe ...
6 years, 6 months ago (2014-06-24 08:04:19 UTC) #2
Sven Panne
On 2014/06/24 08:04:19, Yang wrote: > On 2014/06/18 03:48:33, jianghua.yjh wrote: > > I don't ...
6 years, 6 months ago (2014-06-24 08:10:07 UTC) #3
jianghua
On 2014/06/24 08:04:19, Yang wrote: > On 2014/06/18 03:48:33, jianghua.yjh wrote: > > I don't ...
6 years, 6 months ago (2014-06-24 08:16:36 UTC) #4
jianghua
The CQ bit was checked by jianghua.yjh@alibaba-inc.com
6 years, 6 months ago (2014-06-24 08:30:35 UTC) #5
jianghua
The CQ bit was unchecked by jianghua.yjh@alibaba-inc.com
6 years, 6 months ago (2014-06-24 08:30:36 UTC) #6
Yang
On 2014/06/24 08:30:36, jianghua.yjh wrote: > The CQ bit was unchecked by mailto:jianghua.yjh@alibaba-inc.com LGTM. I'll ...
6 years, 6 months ago (2014-06-24 08:56:26 UTC) #7
Yang
Committed patchset #1 manually as r21960 (presubmit successful).
6 years, 6 months ago (2014-06-24 09:38:05 UTC) #8
jianghua
On 2014/06/24 09:38:05, Yang wrote: > Committed patchset #1 manually as r21960 (presubmit successful). thanks!
6 years, 6 months ago (2014-06-24 09:38:42 UTC) #9
jianghua
On 2014/06/24 09:38:42, jianghua.yjh wrote: > On 2014/06/24 09:38:05, Yang wrote: > > Committed patchset ...
6 years, 6 months ago (2014-06-24 09:42:07 UTC) #10
Yang
6 years, 6 months ago (2014-06-24 09:43:57 UTC) #11
Message was sent while issue was closed. 
On 2014/06/24 09:42:07, jianghua.yjh wrote:
> On 2014/06/24 09:38:42, jianghua.yjh wrote:
> > On 2014/06/24 09:38:05, Yang wrote:
> > > Committed patchset #1 manually as r21960 (presubmit successful).
> > 
> > thanks!
> 
> >>> Patch from Jianghua Yang <mailto:jianghua.jhy@alibaba-inc.com>.
> 
> here mail address got wrong , correct is <mailto:jianghua.yjh@alibaba-inc.com>

oups :/

Powered by Google App Engine
This is Rietveld 408576698