src/full-codegen.cc - Issue 344513004: Fix a potential overflow in SortedListBSearch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 344513004: Fix a potential overflow in SortedListBSearch (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: optimize Deoptimizer::GetOutputInfo Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index 088a9c9a7ed1409ba31667608a3ecdd8b1e8f6a2..f28d1ceed32efe950276c21ecd949384ad0942b3 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -377,6 +377,7 @@ void FullCodeGenerator::PopulateDeoptimizationData(Handle<Code> code) {

int length = bailout_entries_.length();

Handle<DeoptimizationOutputData> data =

DeoptimizationOutputData::New(isolate(), length, TENURED);

+ bailout_entries_.Sort(&BailoutEntry::CompareBailoutId);

for (int i = 0; i < length; i++) {

data->SetAstId(i, bailout_entries_[i].id);

data->SetPcAndState(i, Smi::FromInt(bailout_entries_[i].pc_and_state));

« no previous file with comments | « src/full-codegen.h ('k') | src/utils.h » ('j') | no next file with comments »