Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 344443003: DevTools: Code fixes for the Closure compiler roll (Closed)

Created:
6 years, 6 months ago by apavlov
Modified:
6 years, 6 months ago
Reviewers:
eustas, aandrey, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Code fixes for the Closure compiler roll R=aandrey, eustas, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176404

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -36 lines) Patch
M Source/devtools/front_end/common/DOMExtension.js View 1 22 chunks +65 lines, -9 lines 0 comments Download
M Source/devtools/front_end/components/InspectorView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/extensions/ExtensionAPI.js View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/network/RequestJSONView.js View 3 chunks +11 lines, -3 lines 0 comments Download
M Source/devtools/front_end/network/RequestView.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/profiler/heap_snapshot_worker/JSHeapSnapshot.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/IndexedDBModel.js View 1 7 chunks +17 lines, -5 lines 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorUtils.js View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/StyleSheetOutlineDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/ShortcutRegistry.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 8 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
apavlov
6 years, 6 months ago (2014-06-17 16:18:30 UTC) #1
aandrey
https://codereview.chromium.org/344443003/diff/1/Source/devtools/front_end/common/DOMExtension.js File Source/devtools/front_end/common/DOMExtension.js (right): https://codereview.chromium.org/344443003/diff/1/Source/devtools/front_end/common/DOMExtension.js#newcode636 Source/devtools/front_end/common/DOMExtension.js:636: * @param {?Node|?EventTarget} target this should not be called ...
6 years, 6 months ago (2014-06-17 20:58:37 UTC) #2
apavlov
https://codereview.chromium.org/344443003/diff/1/Source/devtools/front_end/common/DOMExtension.js File Source/devtools/front_end/common/DOMExtension.js (right): https://codereview.chromium.org/344443003/diff/1/Source/devtools/front_end/common/DOMExtension.js#newcode636 Source/devtools/front_end/common/DOMExtension.js:636: * @param {?Node|?EventTarget} target On 2014/06/17 20:58:36, aandrey wrote: ...
6 years, 6 months ago (2014-06-18 07:55:14 UTC) #3
aandrey
lgtm
6 years, 6 months ago (2014-06-18 08:06:31 UTC) #4
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-18 08:06:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/344443003/20001
6 years, 6 months ago (2014-06-18 08:07:41 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 09:15:29 UTC) #7
Message was sent while issue was closed. 
Change committed as 176404

Powered by Google App Engine
This is Rietveld 408576698